Paths

Table of Contentst

Differential D16125

DRW: Split ViewProjectionMatrix in order to increase precision
ClosedPublic
Actions

Authored by Clément Foucault (fclem) on Oct 1 2022, 9:25 PM.

Details

Reviewers

Jeroen Bakker (jbakker)

Commits

rB6306d747b770: DRW: Split ViewProjectionMatrix in order to increase precision

Summary

This also removes the need to compute the persmat and saves some memory
from the ViewInfos struct. This is needed to allow multiview support.

Initial testing found no major performance regression during vertex
heavy workload.

Test file:

test_vertex_perf.blend1 MBDownload

Results:

Platform	Master	Split Matrix
Linux + Mesa + AMD W6600	48 fps	47 fps
Macbook Pro M1	50 fps	51 fps
Linux + NVidia 1080Ti	51 fps	52 fps
Linux + Radeon Vega 64	25.6 fps	26.7 fps

Increased precision when far from origin:

Diff Detail

Repository: rB Blender

Event Timeline

Clément Foucault (fclem) requested review of this revision.Oct 1 2022, 9:25 PM

Clément Foucault (fclem) created this revision.

Harbormaster completed remote builds in B24063: Diff 56366.Oct 1 2022, 9:25 PM

Clément Foucault (fclem) edited the summary of this revision. (Show Details)Oct 3 2022, 2:15 PM

Clément Foucault (fclem) added a project: EEVEE & Viewport.

Clément Foucault (fclem) edited the summary of this revision. (Show Details)Oct 3 2022, 3:39 PM

LGTM.

This revision is now accepted and ready to land.Oct 4 2022, 1:29 PM

Closed by commit rB6306d747b770: DRW: Split ViewProjectionMatrix in order to increase precision (authored by Clément Foucault (fclem)). · Explain WhyOct 5 2022, 8:29 PM

This revision was automatically updated to reflect the committed changes.

Clément Foucault (fclem) added a commit: rB6306d747b770: DRW: Split ViewProjectionMatrix in order to increase precision.

Revision Contents
Changeset List

Path

Size

release/

scripts/

addons

2 lines

source/

blender/

draw/

engines/

eevee/

shaders/

lightprobe_cube_display_vert.glsl

2 lines

lightprobe_grid_display_vert.glsl

2 lines

lightprobe_lib.glsl

2 lines

lightprobe_planar_display_frag.glsl

2 lines

lightprobe_planar_display_vert.glsl

2 lines

object_motion_vert.glsl

4 lines

2 lines

2 lines

11 lines

2 lines

eevee_next/

shaders/

eevee_nodetree_lib.glsl

2 lines

gpencil/

shaders/

gpencil_depth_merge_vert.glsl

2 lines

overlay/

shaders/

overlay_armature_envelope_solid_vert.glsl

2 lines

overlay_armature_shape_solid_vert.glsl

2 lines

overlay_edit_mesh_skin_root_vert.glsl

2 lines

overlay_grid_vert.glsl

2 lines

overlay_motion_path_line_vert.glsl

2 lines

overlay_motion_path_line_vert_no_geom.glsl

4 lines

overlay_motion_path_point_vert.glsl

2 lines

overlay_outline_prepass_gpencil_frag.glsl

2 lines

intern/

3 lines

19 lines

4 lines

8 lines

shaders/

common_view_lib.glsl

13 lines

Diff 56498

View Options

release/scripts/addons

View Options

source/blender/draw/engines/eevee/shaders/lightprobe_cube_display_vert.glsl

View Options

source/blender/draw/engines/eevee/shaders/lightprobe_grid_display_vert.glsl

View Options

source/blender/draw/engines/eevee/shaders/lightprobe_lib.glsl

View Options

source/blender/draw/engines/eevee/shaders/lightprobe_planar_display_frag.glsl

View Options

source/blender/draw/engines/eevee/shaders/lightprobe_planar_display_vert.glsl

View Options

source/blender/draw/engines/eevee/shaders/object_motion_vert.glsl

View Options

source/blender/draw/engines/eevee/shaders/surface_lib.glsl

View Options

source/blender/draw/engines/eevee/shaders/volumetric_frag.glsl

View Options

source/blender/draw/engines/eevee/shaders/volumetric_lib.glsl

View Options

source/blender/draw/engines/eevee/shaders/world_vert.glsl

View Options

source/blender/draw/engines/eevee_next/shaders/eevee_nodetree_lib.glsl

View Options

source/blender/draw/engines/gpencil/shaders/gpencil_depth_merge_vert.glsl

View Options

source/blender/draw/engines/overlay/shaders/overlay_armature_envelope_solid_vert.glsl

View Options

source/blender/draw/engines/overlay/shaders/overlay_armature_shape_solid_vert.glsl

View Options

source/blender/draw/engines/overlay/shaders/overlay_edit_mesh_skin_root_vert.glsl

View Options

source/blender/draw/engines/overlay/shaders/overlay_grid_vert.glsl

View Options

source/blender/draw/engines/overlay/shaders/overlay_motion_path_line_vert.glsl

View Options

source/blender/draw/engines/overlay/shaders/overlay_motion_path_line_vert_no_geom.glsl

View Options

source/blender/draw/engines/overlay/shaders/overlay_motion_path_point_vert.glsl

View Options

source/blender/draw/engines/overlay/shaders/overlay_outline_prepass_gpencil_frag.glsl

View Options

source/blender/draw/intern/draw_manager.h

View Options

source/blender/draw/intern/draw_manager_data.cc

View Options

source/blender/draw/intern/draw_shader_shared.h

View Options

source/blender/draw/intern/draw_view.cc

View Options

source/blender/draw/intern/shaders/common_view_lib.glsl

DRW: Split ViewProjectionMatrix in order to increase precisionClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 56498

release/scripts/addons

source/blender/draw/engines/eevee/shaders/lightprobe_cube_display_vert.glsl

source/blender/draw/engines/eevee/shaders/lightprobe_grid_display_vert.glsl

source/blender/draw/engines/eevee/shaders/lightprobe_lib.glsl

source/blender/draw/engines/eevee/shaders/lightprobe_planar_display_frag.glsl

source/blender/draw/engines/eevee/shaders/lightprobe_planar_display_vert.glsl

source/blender/draw/engines/eevee/shaders/object_motion_vert.glsl

source/blender/draw/engines/eevee/shaders/surface_lib.glsl

source/blender/draw/engines/eevee/shaders/volumetric_frag.glsl

source/blender/draw/engines/eevee/shaders/volumetric_lib.glsl

source/blender/draw/engines/eevee/shaders/world_vert.glsl

source/blender/draw/engines/eevee_next/shaders/eevee_nodetree_lib.glsl

source/blender/draw/engines/gpencil/shaders/gpencil_depth_merge_vert.glsl

source/blender/draw/engines/overlay/shaders/overlay_armature_envelope_solid_vert.glsl

source/blender/draw/engines/overlay/shaders/overlay_armature_shape_solid_vert.glsl

source/blender/draw/engines/overlay/shaders/overlay_edit_mesh_skin_root_vert.glsl

source/blender/draw/engines/overlay/shaders/overlay_grid_vert.glsl

source/blender/draw/engines/overlay/shaders/overlay_motion_path_line_vert.glsl

source/blender/draw/engines/overlay/shaders/overlay_motion_path_line_vert_no_geom.glsl

source/blender/draw/engines/overlay/shaders/overlay_motion_path_point_vert.glsl

source/blender/draw/engines/overlay/shaders/overlay_outline_prepass_gpencil_frag.glsl

source/blender/draw/intern/draw_manager.h

source/blender/draw/intern/draw_manager_data.cc

source/blender/draw/intern/draw_shader_shared.h

source/blender/draw/intern/draw_view.cc

source/blender/draw/intern/shaders/common_view_lib.glsl

DRW: Split ViewProjectionMatrix in order to increase precision
ClosedPublic
Actions

Revision Contents
Changeset List