Paths

Table of Contentst

Fix T101438: Wrong LOD selection after clamping the mip value (Nvidia)
ClosedPublic
Actions

Authored by Miguel Pozo (pragma37) on Oct 2 2022, 6:04 PM.

Details

Reviewers

Jeroen Bakker (jbakker)
Clément Foucault (fclem)

Maniphest Tasks

T101438: Eevee: Screen Space Refraction Artefacts when using low roughness and refraction depth

Commits

rB6c2c3ed2c9be: Fix T101438: Wrong LOD selection after clamping the mip value (Nvidia)

Summary

Fix for T101438

Clamping the mip seems to always set it to 9.0.
I couldn't find an alternative way to avoid triggering the error (ie. min(mip, 9.0)).

In any case, the results with this patch applied look the same to the (correct) ones on AMD.
And, since clamping the max mip to a hardcoded value could result in resolution-depended behavior, I guess disabling the clamp should be ok anyway.

Diff Detail

Repository

rB Blender

Branch

master

Build Status

Buildable 24070
Build 24070: arc lint + arc unit

Event Timeline

Miguel Pozo (pragma37) requested review of this revision.Oct 2 2022, 6:04 PM

Miguel Pozo (pragma37) created this revision.

Harbormaster completed remote builds in B24070: Diff 56379.Oct 2 2022, 6:04 PM

Miguel Pozo (pragma37) edited the summary of this revision. (Show Details)Oct 2 2022, 6:07 PM

Jeroen Bakker (jbakker) added a reviewer: Clément Foucault (fclem).Oct 3 2022, 12:08 PM

Jeroen Bakker (jbakker) added a project: EEVEE & Viewport.

The clamp was introduced because the mip levels might have been specified (allocated) but not populated correctly. But I guess if the sampler mip range is correct (contains the updated downsampled mips), this patch should be ok.

So we should remove the commented out code and commit this to master?

We can commit it as is and remove the comment. I don't even know why the 9 was here since MAX_SCREEN_BUFFERS_LOD_LEVEL is 6. The downsample step should be setting the sampler mip limits accordingly.

This revision is now accepted and ready to land.Oct 3 2022, 3:46 PM

Closed by commit rB6c2c3ed2c9be: Fix T101438: Wrong LOD selection after clamping the mip value (Nvidia) (authored by Miguel Pozo (pragma37), committed by Jeroen Bakker (jbakker)). · Explain WhyOct 4 2022, 1:32 PM

This revision was automatically updated to reflect the committed changes.

Jeroen Bakker (jbakker) added a commit: rB6c2c3ed2c9be: Fix T101438: Wrong LOD selection after clamping the mip value (Nvidia).

Revision Contents
Changeset List

Path

Size

source/

blender/

draw/

engines/

eevee/

shaders/

ssr_lib.glsl

5 lines

Diff 56379

View Options

source/blender/draw/engines/eevee/shaders/ssr_lib.glsl

Fix T101438: Wrong LOD selection after clamping the mip value (Nvidia)ClosedPublicActions