Details
Diff Detail
- Repository
- rB Blender
Event Timeline
Those are some nice improvements, thanks!
I've added a few inline comments for some small adjustments. Once those are addressed, I can land the patch.
| source/blender/editors/animation/anim_channels_defines.c | ||
|---|---|---|
| 4996 | To be consistent, either Shows should be Show, or enable should be enables. I think Show would be better here. | |
| source/blender/editors/animation/drivers.c | ||
| 1260 | I don't think we should do this change. Not all "copy/paste buffers" of Blender actually use the system clipboard. For example, when copy-pasting an object between blend files, nothing actually gets stored on the clipboard -- "copy" just saves the object to a file in a specific location, and "paste" loads that file. | |
| source/blender/editors/animation/drivers.c | ||
|---|---|---|
| 1260 | First time replying to a revision comment so let me know if I just talked back to the president and need to sit back down. I disagree because technically what you're saying makes sense but for a user the word buffer is practically gibberish. The only context they might be aware of it in is in buffering of a video. (Obviously more technical users immediately understand) I'm wondering if it runs afoul of this guideline: Do not use implementation specific language. Use "data-block", not "ID". Do not use terms like "flag", "string", "RNA", "DNA". There is also an error message at 744 that uses clipboard. I can update both if we decide to use copy/paste buffer. if (BLI_listbase_is_empty(&driver_vars_copybuf)) {
BKE_report(reports, RPT_ERROR, "No driver variables in clipboard to paste");
return false; | |
| source/blender/editors/animation/drivers.c | ||
|---|---|---|
| 1260 |
Haha love it :) And by all means stand up for your ideas. Everybody can be wrong, me definitely included. Having a clear discussion with clear points of view / perspectives / opinions only helps.
I agree with you here. Let's keep things as they are now (i.e. as committed). | |