Fix T101275: Edited action in NLA dependency issue
ClosedPublic
Actions

Authored by Nate Rupsis (nrupsis) on Oct 5 2022, 5:29 PM.

Details

Reviewers

Brad Clark (RiggingDojo)
Sybren A. Stüvel (sybren)

Maniphest Tasks

T101275: Regression: Edited action in NLA ignored settings

Commits

rBbfc9d7cadfe8: FIX T101275: Regression in NLA causes Actions to be ignored by Context menu (I.
rBf96b729d7b5a: FIX T101275: Regression in NLA causes Actions to be ignored by Context menu (I.

Summary

D14820 landed a fix for: refreshing The NLA sidebar on creation of a new action & now indicating the selected action channel.
However, it broke the dependency updating for the Action clip (i.e, influence slider).

This fix removing NLA case option from nla_panel_context, which was incorrectly setting the data id, causing the dependency graph not to update the targeted object.

Diff Detail

Repository: rB Blender

Event Timeline

Nate Rupsis (nrupsis) requested review of this revision.Oct 5 2022, 5:29 PM

Nate Rupsis (nrupsis) created this revision.

Harbormaster completed remote builds in B24126: Diff 56479.Oct 5 2022, 5:29 PM

Nate Rupsis (nrupsis) retitled this revision from Removing NlA case option from nla_panel_context, which is incorrectly setting the data id to Fix T101275: Edited action in NLA dependency issue.Oct 5 2022, 5:38 PM

Nate Rupsis (nrupsis) edited the summary of this revision. (Show Details)

Sybren A. Stüvel (sybren) added projects: Animation & Rigging, BF Blender (3.4).Oct 6 2022, 10:57 AM

Sybren A. Stüvel (sybren) edited the summary of this revision. (Show Details)

I can confirm the patch works 👍

ANIMTYPE_NLAACTION shouldn't just be removed from the switch, though. It's better to keep a case: break; for it. It'll give you a spot to put a comment that explains why in this case nothing should happen.

Also if "warning when not all enums are handled in a switch" gets broader compiler support, having this case explicit will avoid such a warning.

Sybren A. Stüvel (sybren) requested changes to this revision.Oct 6 2022, 11:20 AM

This revision now requires changes to proceed.Oct 6 2022, 11:20 AM