Page MenuHome
Differential D16155

Fix Sequencer channels not updating while panning/scaling the view
ClosedPublic
Actions

Authored by Yann Lanthony (yann-lty) on Oct 5 2022, 5:41 PM.

Details

Reviewers
Richard Antalik (ISS)
Maniphest Tasks
T101622: Sequencer channels not updating while panning/scaling the view
Commits
rBc3d0ba3b333c: Fix T101622: Sequencer channels not updating while panning view
Summary

Fix V2D_VIEWSYNC_AREA_VERTICAL flag set to the sequencer toolbar
region instead of the channels region.

Diff Detail

Repository
rB Blender

Event Timeline

Yann Lanthony (yann-lty) requested review of this revision.Oct 5 2022, 5:41 PM
Yann Lanthony (yann-lty) created this revision.
Falk David (filedescriptor) added a task: T101622: Sequencer channels not updating while panning/scaling the view.Oct 5 2022, 5:42 PM
Pratik Borhade (PratikPB2123) added a reviewer: Richard Antalik (ISS).Oct 6 2022, 7:05 AM
Pratik Borhade (PratikPB2123) added projects: Video Sequencer, VFX & Video.
Richard Antalik (ISS) accepted this revision.Oct 7 2022, 1:09 PM

Thanks for fix!

This revision is now accepted and ready to land.Oct 7 2022, 1:09 PM
Yann Lanthony (yann-lty) added a comment.Oct 7 2022, 5:50 PM

Please note that pre-existing sequence editors are still broken only with this patch. This probably needs versioning code too.

Richard Antalik (ISS) added a comment.Oct 7 2022, 6:22 PM

That is good point, versioning code should be added...

Yann Lanthony (yann-lty) updated this revision to Diff 56680.Oct 10 2022, 4:22 PM

Added versioning code

Richard Antalik (ISS) added a comment.Oct 10 2022, 4:53 PM

Thanks for update, looks good for me. Do you want to commit yourself? Just in case I want to remind, to bump subversion, I see a lot of commits by you, but not sure if you know the process...

Yann Lanthony (yann-lty) added a comment.Oct 14 2022, 10:34 AM

Thanks for the review!
About your question: I don't have commit rights, I've authored patches but they were always committed by others.

Closed by commit rBc3d0ba3b333c: Fix T101622: Sequencer channels not updating while panning view (authored by Yann Lanthony (yann-lty), committed by Richard Antalik (ISS)). · Explain WhyOct 19 2022, 8:16 PM
This revision was automatically updated to reflect the committed changes.
Richard Antalik (ISS) added a commit: rBc3d0ba3b333c: Fix T101622: Sequencer channels not updating while panning view.
Richard Antalik (ISS) added a comment.Oct 19 2022, 8:27 PM
In D16155#442601, @Yann Lanthony (yann-lty) wrote:

Thanks for the review!
About your question: I don't have commit rights, I've authored patches but they were always committed by others.

Thanks for info, I have committed the patch.

I would recommend to ask for commit rights either via bf-committers list or on blender.chat. See https://wiki.blender.org/wiki/Process/Commit_Rights for more info.

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
space_sequencer/
2 lines

Diff 56482

View Options

source/blender/editors/space_sequencer/space_sequencer.c

Loading...