New math function to add small bias to zero axis
ClosedPublic
Actions

Authored by Antonio Vazquez (antoniov) on Oct 5 2022, 5:46 PM.

Details

Reviewers

Commits

rB7e5db850dc9d: New math function to add small bias to zero axis
rB51bd26d0faad: New math function to add small bias to zero axis

Summary

In some situations the zero axis can produce problems and need to add a small bias.

This function adds a small bias using the orthogonal result of the other valid axis.

Diff Detail

Repository

rB Blender

Branch

temp-new-math-bias (branched from master)

Build Status

Buildable 24129
Build 24129: arc lint + arc unit

Event Timeline

Antonio Vazquez (antoniov) requested review of this revision.Oct 5 2022, 5:46 PM

Antonio Vazquez (antoniov) created this revision.

Harbormaster completed remote builds in B24129: Diff 56485.Oct 5 2022, 5:46 PM

@Hans Goudey (HooglyBoogly) Do you think function name is ok? do you have a better name?

Clément Foucault (fclem) added inline comments.Oct 5 2022, 5:50 PM

source/blender/blenlib/intern/math_matrix.c
3121–3123	Could go as far as making the comparisons here.

Antonio Vazquez (antoniov) added inline comments.Oct 5 2022, 6:43 PM

source/blender/blenlib/intern/math_matrix.c
3121–3123	What do you mean?

Clément Foucault (fclem) added inline comments.Oct 5 2022, 6:49 PM

source/blender/blenlib/intern/math_matrix.c
3121–3123

Fix review comments

Harbormaster completed remote builds in B24131: Diff 56491.Oct 5 2022, 7:00 PM

Clément Foucault (fclem) accepted this revision.Oct 5 2022, 10:08 PM

This revision is now accepted and ready to land.Oct 5 2022, 10:08 PM

Closed by commit rB51bd26d0faad: New math function to add small bias to zero axis (authored by Antonio Vazquez (antoniov)). · Explain WhyOct 5 2022, 10:12 PM

This revision was automatically updated to reflect the committed changes.

Antonio Vazquez (antoniov) added a commit: rB51bd26d0faad: New math function to add small bias to zero axis.

Philipp Oeser (lichtwerk) added a commit: rB7e5db850dc9d: New math function to add small bias to zero axis.Oct 17 2022, 4:31 PM

Revision Contents
Changeset List

Path

Size

source/

blender/

blenlib/

BLI_math_matrix.h

2 lines

intern/

math_matrix.c

28 lines

Diff 56485

View Options

source/blender/blenlib/BLI_math_matrix.h