Differential D16163

Fix T101628: Correct frame node intersection in add reroute operator
ClosedPublic
Actions

Authored by Leon Schittek (lone_noel) on Oct 5 2022, 11:25 PM.

Tags

None

Subscribers

None

Details

Reviewers

Hans Goudey (HooglyBoogly)

Maniphest Tasks

T101628: new reroutes become children of existing far off frames

Commits

rB707c7de21f0b: Fix T101628: Correct frame node intersection in add reroute operator

Summary

Fix reroute nodes added via the cut link gesture being parented to the
wrong frame node.

The frame's bounds that are used for the intersection test with the
newly added reroute are in view space, but the reroute's location was
given in the node tree's coordinate space, when the add reroute
operator was recently refactored (56193eccf646).

Diff Detail

Repository: rB Blender

Event Timeline

Leon Schittek (lone_noel) requested review of this revision.Oct 5 2022, 11:25 PM

Leon Schittek (lone_noel) created this revision.

Harbormaster completed remote builds in B24141: Diff 56507.Oct 5 2022, 11:25 PM

Leon Schittek (lone_noel) added a task: T101628: new reroutes become children of existing far off frames.Oct 5 2022, 11:26 PM

Thanks for looking into the bug. Looks like the order of operations with division got me. One statement doing too much I suppose.

This revision is now accepted and ready to land.Oct 5 2022, 11:37 PM

Closed by commit rB707c7de21f0b: Fix T101628: Correct frame node intersection in add reroute operator (authored by Leon Schittek (lone_noel)). · Explain WhyOct 6 2022, 7:36 AM

This revision was automatically updated to reflect the committed changes.

Leon Schittek (lone_noel) added a commit: rB707c7de21f0b: Fix T101628: Correct frame node intersection in add reroute operator.

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

space_node/

11 lines

Diff 56517

source/blender/editors/space_node/node_add.cc

Loading...