Fix T101618: Freeze when reloading a library in certain situation
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Oct 6 2022, 12:11 PM.

Details

Reviewers

Bastien Montagne (mont29)
Brecht Van Lommel (brecht)

Maniphest Tasks

T101618: Freeze when reloading a library while having an Object property with a custom getter function defined in Python

Commits

rB86f8898ccd3b: Fix T101618: Freeze when reloading a library in certain situation
rB423c1366b05e: Fix T101618: Freeze when reloading a library in certain situation

Summary

Freeze happened when reloading a library while having an Object property
with a custom getter function defined in Python.

Just piggybacking on rB62eb21e3ce87, this just applies the same fix (use
the BPy_BEGIN/END_ALLOW_THREADS macros) to the places where the freeze
happens in the report situation.

All credit goes to @Brecht Van Lommel (brecht) and @Bastien Montagne (mont29).

Diff Detail

Repository: rB Blender

Event Timeline

Philipp Oeser (lichtwerk) requested review of this revision.Oct 6 2022, 12:11 PM

Philipp Oeser (lichtwerk) created this revision.

Harbormaster completed remote builds in B24147: Diff 56524.Oct 6 2022, 12:11 PM

Philipp Oeser (lichtwerk) added projects: Core, Overrides, Python API.Oct 6 2022, 12:11 PM

Normally this should be added in the RNA code so they only affect calling functions from Python.

This revision now requires changes to proceed.Oct 6 2022, 12:43 PM

encapsulate the whole of WM_lib_reload with the THREADS macros in RNA (instead of the more distinct places in BKE_blendfile_library_relocate)

Harbormaster completed remote builds in B24149: Diff 56526.Oct 6 2022, 1:13 PM

Brecht Van Lommel (brecht) accepted this revision.Oct 6 2022, 1:16 PM

This revision is now accepted and ready to land.Oct 6 2022, 1:16 PM

Yann Lanthony (yann-lty) awarded a token.Oct 6 2022, 1:37 PM

Bastien Montagne (mont29) accepted this revision.Oct 6 2022, 2:16 PM

Closed by commit rB423c1366b05e: Fix T101618: Freeze when reloading a library in certain situation (authored by Philipp Oeser (lichtwerk)). · Explain WhyOct 6 2022, 2:20 PM

This revision was automatically updated to reflect the committed changes.

Philipp Oeser (lichtwerk) added a commit: rB423c1366b05e: Fix T101618: Freeze when reloading a library in certain situation.

Philipp Oeser (lichtwerk) added a commit: rB86f8898ccd3b: Fix T101618: Freeze when reloading a library in certain situation.Oct 17 2022, 4:31 PM

Revision Contents
Changeset List

Path

Size

source/

blender/

makesrna/

intern/

rna_ID.c

15 lines

Diff 56533

View Options

source/blender/makesrna/intern/rna_ID.c

Fix T101618: Freeze when reloading a library in certain situationClosedPublicActions