Page MenuHome
Differential D16168

Adding function to check if an animation container has grease pencil channels
ClosedPublic
Actions

Authored by Amelie Fondevilla (afonde) on Oct 6 2022, 12:27 PM.

Details

Reviewers
Sybren A. Stüvel (sybren)
Commits
rB0b45d3e38662: Refactor: adding function to check if an animation container has grease pencil…
rB412d670e9c58: Refactor: adding function to check if an animation container has grease pencil…

Diff Detail

Repository
rB Blender
Branch
add-animdat-gpencil-filter (branched from master)
Build Status
Buildable 24148
Build 24148: arc lint + arc unit

Event Timeline

Amelie Fondevilla (afonde) requested review of this revision.Oct 6 2022, 12:27 PM
Amelie Fondevilla (afonde) created this revision.
Harbormaster completed remote builds in B24148: Diff 56525.Oct 6 2022, 12:27 PM
Amelie Fondevilla (afonde) added a reviewer: Sybren A. Stüvel (sybren).Oct 6 2022, 12:33 PM
Sybren A. Stüvel (sybren) accepted this revision.Oct 6 2022, 4:47 PM

Nice!

Just two tiny things. You can change those when committing the patch, no need to re-review.

source/blender/editors/animation/anim_filter.c
420

This can be const eAnimCont_Types type

source/blender/editors/include/ED_anim_api.h
523

Comments should end with a period.

This revision is now accepted and ready to land.Oct 6 2022, 4:47 PM
Closed by commit rB412d670e9c58: Refactor: adding function to check if an animation container has grease pencil… (authored by Amelie Fondevilla (afonde)). · Explain WhyOct 7 2022, 11:07 AM
This revision was automatically updated to reflect the committed changes.
Amelie Fondevilla (afonde) added a commit: rB412d670e9c58: Refactor: adding function to check if an animation container has grease pencil….
Philipp Oeser (lichtwerk) added a commit: rB0b45d3e38662: Refactor: adding function to check if an animation container has grease pencil….Oct 26 2022, 10:55 AM

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
animation/
5 lines
include/
5 lines
space_action/
16 lines

Diff 56525

View Options

source/blender/editors/animation/anim_filter.c

Loading...
View Options

source/blender/editors/include/ED_anim_api.h

Loading...
View Options

source/blender/editors/space_action/action_select.c

Loading...