Page MenuHome

Animation: Expose "mute" for drivers in their properties UI
ClosedPublic

Authored by Sybren A. Stüvel (sybren) on Oct 6 2022, 6:56 PM.

Details

Summary

In the driver editor and the "edit driver" popover, add a checkbox that can mute the driver. This is the same functionality as the checkbox in the driver editor's channel list, but then exposed in a different place in the UI.

This is for convenience, such that a driver can now be muted by right-clicking on the driven property, choosing "Edit Driver", then muting it there. The same checkbox was added to the regular driver editor's header for consistency.

Driver EditorEdit Driver pop-over

Manifest Task: T101592

Diff Detail

Repository
rB Blender

Event Timeline

Sybren A. Stüvel (sybren) requested review of this revision.Oct 6 2022, 6:56 PM
Sybren A. Stüvel (sybren) created this revision.
Sybren A. Stüvel (sybren) edited the summary of this revision. (Show Details)
  • Tiny code cleanup

A checkbox before Driver Settings: doesn't seem right to me. The word Settings is redundant anyway, so if you just change it to Driver: it's all good for me.

source/blender/editors/space_graph/graph_buttons.c
924

The 20 * can be removed I think, since we figured the issue was actually that inverted checkboxes were broken :)

Not worth a re-review after mentioned small changes were addressed.

This revision is now accepted and ready to land.Oct 6 2022, 7:05 PM
Sybren A. Stüvel (sybren) marked an inline comment as done.Oct 6 2022, 7:07 PM