I18n: disambiguate message "World"
ClosedPublic
Actions

Authored by Damien Picard (pioverfour) on Oct 8 2022, 11:24 PM.

Details

Reviewers

Bastien Montagne (mont29)

Maniphest Tasks

T43295: Translation disambiguation requests

Commits

rB7d7318f6c59c: I18n: disambiguate message "World"

Summary

The confusion is about World as an ID type, and the World coordinates.

Use no context for the latter, and either BLT_I18NCONTEXT_ID_WORLD,
or other more fine-grained contexts when needed as part of enums for the
former.

The message from the custom HDRI installation operator cannot be
disambiguated right now, because Python enums don't support contexts.

Ref T43295

Diff Detail

Repository: rB Blender

Event Timeline

Damien Picard (pioverfour) requested review of this revision.Oct 8 2022, 11:24 PM

Damien Picard (pioverfour) created this revision.

Damien Picard (pioverfour) mentioned this in T43295: Translation disambiguation requests.Oct 9 2022, 1:32 AM

Not sure why you are using BLT_I18NCONTEXT_ID_ID instead of BLT_I18NCONTEXT_ID_WORLD here?

This revision now requires changes to proceed.Oct 10 2022, 12:55 PM

This is what is already used elsewhere for this meaning of “World”, so I figured I might as well reuse it.
Also, from the translators’ point of view, using "World" to disambiguate "World" is, uh, not really helpful. :D By using ID, it’s hopefully clear that it’s about the datablock type.

Thing is, when we disambiguate something for a specific ID type, makes more sense to use proper context for that ID type... ID_ID is typically used for properties that can e.g. set a type of ID (i.e. they may cover all ID types).