Differential D16198

Fix (partial) T92713: SVG importer: Implicit close keeps current point
ClosedPublic
Actions

Authored by Lin Hsu (linhsu0723) on Oct 9 2022, 5:04 AM.

Details

Reviewers

Sergey Sharybin (sergey)

Commits

rBAa2e69343eb08: Fix (partial) T92713: SVG importer: Implicit close keeps current point

Summary

Don't change current point coordinate for implicit path close.
This can fix some broken paths in T92713.

Diff Detail

Repository

rBA Blender Add-ons

Branch

fix-T92713-partial

Build Status

Buildable 24192
Build 24192: arc lint + arc unit

Event Timeline

Lin Hsu (linhsu0723) requested review of this revision.Oct 9 2022, 5:04 AM

Lin Hsu (linhsu0723) created this revision.

Harbormaster completed remote builds in B24192: Diff 56648.Oct 9 2022, 5:04 AM

Before:

curve resolution	12 (default)	64
image
#broken icons	82	82

Now:

curve resolution	12 (default)	64
image
#broken icons	72	71

There are 3 images for each icon: Blender rendering, CairoSVG rendering, abs(diff).
The number is the MSE of the pixels with alpha !=0 and alpha != 1 in both renderings. These pixels are borders which are all that matters for such icons.
Icons with MSE > 0.0004 are treated as broken and are framed with red.

Lin Hsu (linhsu0723) retitled this revision from Fix T92713 (partial): SVG importer: Implicit close keeps current point to Fix (partial) T92713: SVG importer: Implicit close keeps current point.Oct 9 2022, 5:15 AM

Sergey Sharybin (sergey) accepted this revision.Oct 11 2022, 9:53 AM

This revision is now accepted and ready to land.Oct 11 2022, 9:53 AM

Closed by commit rBAa2e69343eb08: Fix (partial) T92713: SVG importer: Implicit close keeps current point (authored by Lin Hsu (linhsu0723), committed by Sergey Sharybin (sergey)). · Explain WhyOct 11 2022, 9:55 AM

This revision was automatically updated to reflect the committed changes.

Sergey Sharybin (sergey) added a commit: rBAa2e69343eb08: Fix (partial) T92713: SVG importer: Implicit close keeps current point.