Page MenuHome
Differential D16213

deps_builder: fix hardcoded path
ClosedPublic
Actions

Authored by Ray Molenkamp (LazyDodo) on Oct 10 2022, 7:21 PM.

Details

Reviewers
Dalai Felinto (dfelinto)
Brecht Van Lommel (brecht)
Commits
rB14c218b3fd9e: deps_builder: fix hardcoded path
Summary

the windows builder has 2 different build folders for
the debug and release libs, hardcoding the path like
this leads to an extra 1GB of downloaded files. The
windows builder supplies a single PACKAGE_DIR for both
but gets ignored.

I don't see a good reason to hardcode it like this.
I validated make make_source_archive still works on
linux after the change.

Diff Detail

Repository
rB Blender
Branch
tmp_package_dir (branched from master)
Build Status
Buildable 24208
Build 24208: arc lint + arc unit

Event Timeline

Ray Molenkamp (LazyDodo) requested review of this revision.Oct 10 2022, 7:21 PM
Ray Molenkamp (LazyDodo) created this revision.
Harbormaster completed remote builds in B24208: Diff 56688.Oct 10 2022, 7:21 PM
Brecht Van Lommel (brecht) accepted this revision.Oct 12 2022, 6:06 PM
This revision is now accepted and ready to land.Oct 12 2022, 6:06 PM
Dalai Felinto (dfelinto) accepted this revision.Oct 13 2022, 10:23 AM

I didn' t test it, but If it works +1

Sybren A. Stüvel (sybren) removed a subscriber: Sybren A. Stüvel (sybren).Oct 13 2022, 2:12 PM
Closed by commit rB14c218b3fd9e: deps_builder: fix hardcoded path (authored by Ray Molenkamp (LazyDodo)). · Explain WhyOct 26 2022, 1:01 AM
This revision was automatically updated to reflect the committed changes.
Ray Molenkamp (LazyDodo) added a commit: rB14c218b3fd9e: deps_builder: fix hardcoded path.

Revision Contents
Changeset List

PathSize
build_files/
build_environment/
cmake/
4 lines

Diff 56688

View Options

build_files/build_environment/cmake/options.cmake

Loading...