Page MenuHome
Differential D16222

Use as few arccosines as possible
ClosedPublic
Actions

Authored by Weizhen Huang (weizhen) on Oct 11 2022, 7:34 PM.

Details

Reviewers
Brecht Van Lommel (brecht)
Commits
rB5366920563a3: Use as few arccosines as possible

Diff Detail

Repository
rB Blender
Branch
soc-2022-many-lights-sampling
Build Status
Buildable 24226
Build 24226: arc lint + arc unit

Event Timeline

Weizhen Huang (weizhen) requested review of this revision.Oct 11 2022, 7:34 PM
Weizhen Huang (weizhen) created this revision.
Harbormaster completed remote builds in B24226: Diff 56721.Oct 11 2022, 7:34 PM
Brecht Van Lommel (brecht) added a reviewer: Brecht Van Lommel (brecht).Oct 12 2022, 12:25 PM
Brecht Van Lommel (brecht) accepted this revision.Oct 13 2022, 3:42 PM

It looks correct to me. If you've verified the regression tests are identical before and after this change, you can commit it.

This revision is now accepted and ready to land.Oct 13 2022, 3:42 PM
Alaska (Alaska) closed this revision.Oct 14 2022, 12:21 AM
Alaska (Alaska) added a commit: rB5366920563a3: Use as few arccosines as possible.
Alaska (Alaska) added a subscriber: Alaska (Alaska).

This has been commited to the Many Lights Sampling branch.

Revision Contents
Changeset List

PathSize
intern/
cycles/
kernel/
light/
80 lines

Diff 56721

View Options

intern/cycles/kernel/light/light_tree.h

Loading...