Page MenuHome
Differential D16235

Cycles: Enable MNEE on Metal (macOS >= 13)
ClosedPublic
Actions

Authored by Michael Jones (michael_jones) on Oct 12 2022, 2:13 PM.

Details

Reviewers
Brecht Van Lommel (brecht)
Commits
rBba67a383fa39: Cycles: Enable MNEE on Metal (macOS >= 13)
Summary

This patch enables MNEE on macOS >= 13. There was an inefficiency in the calculation of spill requirements, fixed as of macOS 13. This patch also adds a temporary inlining workaround for a Metal compiler bug which causes mnee_compute_constraint_derivatives to behave incorrectly.

Diff Detail

Repository
rB Blender

Event Timeline

Michael Jones (michael_jones) requested review of this revision.Oct 12 2022, 2:13 PM
Michael Jones (michael_jones) created this revision.
Harbormaster completed remote builds in B24239: Diff 56755.Oct 12 2022, 2:13 PM
Brecht Van Lommel (brecht) accepted this revision.Oct 12 2022, 5:59 PM

Looks good to me, assuming you leave out the change to the test blacklist.

tests/python/cycles_render_tests.py
36–37

We can't remove this until the buildbot upgrades to macOS 13, otherwise tests will fail.

This revision is now accepted and ready to land.Oct 12 2022, 5:59 PM
Michael Jones (michael_jones) updated this revision to Diff 56759.Oct 12 2022, 6:06 PM
  • Re-add the underwater_caustics / MNEE test until the buildbot upgrades to macOS 13.
Harbormaster completed remote builds in B24243: Diff 56759.Oct 12 2022, 6:06 PM
Michael Jones (michael_jones) marked an inline comment as done.Oct 12 2022, 6:06 PM
Brecht Van Lommel (brecht) accepted this revision.Oct 12 2022, 6:06 PM
Closed by commit rBba67a383fa39: Cycles: Enable MNEE on Metal (macOS >= 13) (authored by Michael Jones (michael_jones)). · Explain WhyOct 12 2022, 6:07 PM
This revision was automatically updated to reflect the committed changes.
Michael Jones (michael_jones) added a commit: rBba67a383fa39: Cycles: Enable MNEE on Metal (macOS >= 13).
William Reynish (billreynish) awarded a token.Oct 12 2022, 9:03 PM

Revision Contents
Changeset List

PathSize
intern/
cycles/
device/
metal/
4 lines
kernel/
integrator/
10 lines
6 lines
tests/
python/
2 lines

Diff 56761

View Options

intern/cycles/device/metal/device_impl.mm

Loading...
View Options

intern/cycles/kernel/integrator/mnee.h

Loading...
View Options

intern/cycles/kernel/types.h

Loading...
View Options

tests/python/cycles_render_tests.py

Loading...