Page MenuHome
Differential D16238

Returns conditioned light_tree_pdf for MIS, consistent with light_tree_sample
ClosedPublic
Actions

Authored by Weizhen Huang (weizhen) on Oct 12 2022, 6:14 PM.

Details

Reviewers
Brecht Van Lommel (brecht)
Commits
rB034924c1ee79: Returns conditioned light_tree_pdf for MIS, consistent with light_tree_sample

Diff Detail

Repository
rB Blender
Branch
soc-2022-many-lights-sampling
Build Status
Buildable 24245
Build 24245: arc lint + arc unit

Event Timeline

Weizhen Huang (weizhen) requested review of this revision.Oct 12 2022, 6:14 PM
Weizhen Huang (weizhen) created this revision.
Harbormaster completed remote builds in B24245: Diff 56762.Oct 12 2022, 6:14 PM
Brecht Van Lommel (brecht) added a reviewer: Brecht Van Lommel (brecht).Oct 12 2022, 6:22 PM
Brecht Van Lommel (brecht) added a comment.Oct 13 2022, 3:51 PM

This implementation looks easier to understand.

intern/cycles/kernel/light/light_tree.h
620

This assumes that total_reservoir_weight is complete at this point. Which seems to be the case due to the order of traversal, where the target branch is always at stack[0] and so will be traversed last.

There should either be a comment explaining that, or we can compute pdf_reservoir at the end of the function again.

Brecht Van Lommel (brecht) accepted this revision.Oct 13 2022, 4:05 PM
This revision is now accepted and ready to land.Oct 13 2022, 4:05 PM
Alaska (Alaska) closed this revision.Oct 14 2022, 12:22 AM
Alaska (Alaska) added a commit: rB034924c1ee79: Returns conditioned light_tree_pdf for MIS, consistent with light_tree_sample.
Alaska (Alaska) added a subscriber: Alaska (Alaska).

This has been commited to the Many Lights Sampling branch

Revision Contents
Changeset List

PathSize
intern/
cycles/
kernel/
light/
115 lines

Diff 56762

View Options

intern/cycles/kernel/light/light_tree.h

Loading...