See T46678 for details...
Details
Details
Diff Detail
Diff Detail
- Repository
- rB Blender
Event Timeline
Comment Actions
Generally is fine if it's working, but some minor feedback.
| source/blender/editors/transform/transform_generics.c | ||
|---|---|---|
| 954 | Are there other effect types which needs special handle here? Could it be some generic rule here about this? Some comment in the code about such a case wouldn't hurt at all. And maybe make it an utility function or maybe even add a flag to effect typeinfo about this. | |
Comment Actions
Thanks for the review, will update patch and commit. :)
| source/blender/editors/transform/transform_generics.c | ||
|---|---|---|
| 954 | Afaik, those are the only two types (others either are self-contained, like color or text generators, or have specific dependencies through seq1/2/3 members). Will add another _tx_test func for this, indeed better than keeping this check just here. | |