Disable curve map & profile zoom buttons when appropriate
ClosedPublic
Actions

Authored by Colin Basnett (cmbasnett) on Oct 14 2022, 3:17 AM.

Details

Reviewers

Brecht Van Lommel (brecht)
Campbell Barton (campbellbarton)

Commits

rB4dd19a1ad60e: UI: disable curve map & profile zoom buttons at max/min zoom level

Summary

This diff disables the zoom in and out buttons on the "curve map" (e.g., Float Curve node) and the "curve profile" (e.g., bevel curve profile) when they would have no effect.

This also removes an incorrect comment that indicates the maximum zoom level was 20x when in fact it was 25x.

The magic zoom factor has been moved to a #define named CURVE_ZOOM_MAX.

Before	After

Diff Detail

Repository: rB Blender

Event Timeline

Colin Basnett (cmbasnett) requested review of this revision.Oct 14 2022, 3:17 AM

Colin Basnett (cmbasnett) created this revision.

Harbormaster completed remote builds in B24257: Diff 56796.Oct 14 2022, 3:18 AM

Colin Basnett (cmbasnett) edited the summary of this revision. (Show Details)Oct 14 2022, 3:46 AM

Colin Basnett (cmbasnett) added a project: User Interface.

Colin Basnett (cmbasnett) added reviewers: Brecht Van Lommel (brecht), Campbell Barton (campbellbarton).Oct 14 2022, 5:14 AM

Colin Basnett (cmbasnett) edited the summary of this revision. (Show Details)Oct 14 2022, 5:55 AM

Julien Kaspar (JulienKaspar) awarded a token.Oct 14 2022, 9:50 AM

Charlie Jolly (charlie) awarded a token.Oct 15 2022, 12:36 AM

Pablo Vazquez (pablovazquez) awarded a token.Oct 15 2022, 3:21 PM

Brecht Van Lommel (brecht) accepted this revision.Nov 14 2022, 2:03 PM

This revision is now accepted and ready to land.Nov 14 2022, 2:03 PM

Closed by commit rB4dd19a1ad60e: UI: disable curve map & profile zoom buttons at max/min zoom level (authored by Colin Basnett (cmbasnett), committed by Brecht Van Lommel (brecht)). · Explain WhyNov 14 2022, 2:05 PM

This revision was automatically updated to reflect the committed changes.

Brecht Van Lommel (brecht) added a commit: rB4dd19a1ad60e: UI: disable curve map & profile zoom buttons at max/min zoom level.

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

interface/

interface_templates.c

48 lines

Diff 57597

View Options

source/blender/editors/interface/interface_templates.c

Disable curve map & profile zoom buttons when appropriateClosedPublicActions