Paths

Table of Contentst

Differential D16253

Cycles: Allow Intel GPUs under Metal
ClosedPublic
Actions

Authored by Morteza Mostajab (mmostajab) on Oct 14 2022, 5:29 PM.

Details

Reviewers

Brecht Van Lommel (brecht)

Maniphest Tasks

T92212: Cycles Metal device

Commits

rBf9f834068e38: Cycles: Allow Intel GPUs under Metal
rBe6902d19a0d8: Cycles: Allow Intel GPUs under Metal

Summary

Known Issues:

Command buffer failures when using binary archives (binary archives is disabled for Intel GPUs as a workaround)
Wrong texture sampler being applied (to be addressed in the future)

Ref T92212

Diff Detail

Repository

rB Blender

Branch

master

Build Status

Buildable 24261
Build 24261: arc lint + arc unit

Event Timeline

Morteza Mostajab (mmostajab) requested review of this revision.Oct 14 2022, 5:29 PM

Morteza Mostajab (mmostajab) created this revision.

Harbormaster completed remote builds in B24261: Diff 56809.Oct 14 2022, 5:29 PM

Morteza Mostajab (mmostajab) edited the summary of this revision. (Show Details)Oct 14 2022, 5:31 PM

Morteza Mostajab (mmostajab) added a task: T92212: Cycles Metal device.

Thanks.

I see there is a workaround for the binary archives in the patch, But what is the impact of the texture sampler issue for users?

Alaska (Alaska) added a subscriber: Alaska (Alaska).Oct 14 2022, 11:37 PM

In D16253#442672, @Brecht Van Lommel (brecht) wrote:

I see there is a workaround for the binary archives in the patch, But what is the impact of the texture sampler issue for users?

Impact of texture sampler issue on the final image is not visible, but when comes to comparing images pixel-by-pixel it is easily detected. Checked out the map, and shading on the chair below map.

Classroom rendered on Intel UHD 630:

Classroom rendered on Apple M1 Max:

Classroom rendered on AMD Radeon 5500M:

We have an Intel specific workaround for it, but it is not very clean.

Thanks, looks good to commit then.

But can you clarify what exactly is different, is it not respecting the texture interpolation mode (nearest, bilinear, bicubic)?

This revision is now accepted and ready to land.Oct 17 2022, 12:03 PM

In D16253#443024, @Brecht Van Lommel (brecht) wrote:

Thanks, looks good to commit then.

But can you clarify what exactly is different, is it not respecting the texture interpolation mode (nearest, bilinear, bicubic)?

There is a compiler bug on Intel, causing the sampler index 0 (sid=0) always to be taken in ccl_gpu_tex_object_read_2D and ccl_gpu_tex_object_read_3D. We have a fix for it that I will commit.

Cycles: Workaround for intel MSL compiler issue that picks sampler

index 0, no matter what is the sid value

Harbormaster completed remote builds in B24335: Diff 56954.Oct 19 2022, 2:20 PM

Kuutti Taavitsainen (KudeKube) added a subscriber: Kuutti Taavitsainen (KudeKube).Oct 19 2022, 5:39 PM

Thanks. I guess @Michael Jones (michael_jones) will commit this?

Yes, he will. Thanks @Brecht Van Lommel (brecht)

Closed by commit rBe6902d19a0d8: Cycles: Allow Intel GPUs under Metal (authored by Morteza Mostajab (mmostajab), committed by Michael Jones (michael_jones)). · Explain WhyOct 19 2022, 6:10 PM

This revision was automatically updated to reflect the committed changes.

Michael Jones (michael_jones) added a commit: rBe6902d19a0d8: Cycles: Allow Intel GPUs under Metal.

This caused a build error on the buildbot:
https://builder.blender.org/admin/#/builders/31/builds/7069/steps/6/logs/stdio

Is this feature only available in the macOS 13 beta SDK?
https://developer.apple.com/documentation/metal/mtllibraryoptimizationlevel

Upgrading our buildbot machines would wait at least until macOS 13 is out of beta.

Yes, that feature is only supported by macOS 13 SDK. But we are guarding it with if(@available(macos 13.0, *)). I wonder why it gets compiled on older SDKs. I will try to check it.

Brecht Van Lommel (brecht) mentioned this in rB193b456d2db8: Fix macOS build error after recent changes to enable Intel GPUs.Oct 19 2022, 8:35 PM

I committed a fix in rB193b456d2db8: Fix macOS build error after recent changes to enable Intel GPUs.

In D16253#443898, @Brecht Van Lommel (brecht) wrote:

Is this feature only available in the macOS 13 beta SDK?
https://developer.apple.com/documentation/metal/mtllibraryoptimizationlevel

Upgrading our buildbot machines would wait at least until macOS 13 is out of beta.

You should be able to install the Xcode 14 beta on machine running macOS < 13.

I guess Xcode 14.1 stable will be released soon now that macOS 13 is out, I'll wait a bit for that.

We upgraded all the buildbot workers to Xcode 14.1 now, so the next daily build should have Intel GPU rendering support.

Brecht Van Lommel (brecht) added a commit: rBf9f834068e38: Cycles: Allow Intel GPUs under Metal.Nov 28 2022, 7:27 PM

Brecht Van Lommel (brecht) mentioned this in rB86abbf717691: Fix macOS build error after recent changes to enable Intel GPUs.