Depsgraph: Wrong copy-on-write update after depsgraph rebuild.
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on Oct 17 2022, 4:03 PM.

Details

Reviewers

Bastien Montagne (mont29)
Sybren A. Stüvel (sybren)

Maniphest Tasks

T101797: Regression: Geometry Node: Assert and crash: Add new material on object with geometry nodes

Commits

rB619ce8392b21: Depsgraph: wrong copy-on-write update after depsgraph rebuild

Summary

DepsgraphNodeBuilder::foreach_id_cow_detect_need_for_update_callback seems to only make sense for id types that actually support cow.

In this test file, the node tree is tagged with ID_RECALC_COPY_ON_WRITE after unrelated changes (e.g. when adding a new object). That can be seen in the terminal after applying P3260. That happens because it the node tree has a reference to a font which does not use cow, but does have an id node in the depsgraph.

update_tag_bug.blend811 KBDownload

Diff Detail

Repository

rB Blender

Branch

fix-wrong-update (branched from master)

Build Status

Buildable 24287
Build 24287: arc lint + arc unit

Event Timeline

Jacques Lucke (JacquesLucke) requested review of this revision.Oct 17 2022, 4:03 PM

Jacques Lucke (JacquesLucke) created this revision.

Harbormaster completed remote builds in B24287: Diff 56864.Oct 17 2022, 4:03 PM

Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)Oct 17 2022, 4:07 PM

Jacques Lucke (JacquesLucke) added a reviewer: Sergey Sharybin (sergey).

Jacques Lucke (JacquesLucke) added a task: T101797: Regression: Geometry Node: Assert and crash: Add new material on object with geometry nodes.

Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)Oct 17 2022, 4:41 PM

Jacques Lucke (JacquesLucke) retitled this revision from Fix T101797: Wrong depsgraph update tag. to Depsgraph: Wrong copy-on-write update after depsgraph rebuild..Oct 18 2022, 11:27 AM

Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)

Jacques Lucke (JacquesLucke) removed a reviewer: Sergey Sharybin (sergey).

Jacques Lucke (JacquesLucke) added reviewers: Bastien Montagne (mont29), Sybren A. Stüvel (sybren).

Fix sounds good, indeed if the ID type is never 'CoW-able', there is no point in going further here, since that pointer can never point to a CoW ID, only always to the original ID.

For reference, this whole bit of code comes from rBcf4258673755: Fix T85752: Collection Instance Crash when instancing collections with disabled….