Fix T100988: Flickering when using sculpt brush in drag dot mode.
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on Oct 20 2022, 1:54 PM.

Details

Reviewers

Julien Kaspar (JulienKaspar)
Joseph Eagar (joeedh)
Hans Goudey (HooglyBoogly)

Maniphest Tasks

T100988: Regression: Sculpt Layer brush "strength" jittering while in Drag Dot mode

Commits

rBdc609d9f1f6e: Fix T100988: flickering when using sculpt brush in drag dot mode

Summary

The issue was that the raycasting in SCULPT_stroke_get_location was done on the result of the previous brush stroke. However, the original surface should be used instead because that is what the dragged dot will be applied on.

Diff Detail

Repository: rB Blender

Event Timeline

Jacques Lucke (JacquesLucke) requested review of this revision.Oct 20 2022, 1:54 PM

Jacques Lucke (JacquesLucke) created this revision.

Harbormaster completed remote builds in B24353: Diff 56990.Oct 20 2022, 1:54 PM

Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)Oct 20 2022, 1:57 PM

Jacques Lucke (JacquesLucke) added reviewers: Julien Kaspar (JulienKaspar), Joseph Eagar (joeedh).

Jacques Lucke (JacquesLucke) added a task: T100988: Regression: Sculpt Layer brush "strength" jittering while in Drag Dot mode.

Works fine for me.

This revision is now accepted and ready to land.Oct 20 2022, 2:28 PM

Jacques Lucke (JacquesLucke) added a reviewer: Hans Goudey (HooglyBoogly).Nov 7 2022, 8:42 PM

Hans Goudey (HooglyBoogly) accepted this revision.Nov 7 2022, 11:29 PM

Closed by commit rBdc609d9f1f6e: Fix T100988: flickering when using sculpt brush in drag dot mode (authored by Jacques Lucke (JacquesLucke)). · Explain WhyNov 8 2022, 11:47 AM

This revision was automatically updated to reflect the committed changes.

Jacques Lucke (JacquesLucke) added a commit: rBdc609d9f1f6e: Fix T100988: flickering when using sculpt brush in drag dot mode.

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

sculpt_paint/

paint_stroke.c

2 lines

Diff 57341

View Options

source/blender/editors/sculpt_paint/paint_stroke.c

Fix T100988: Flickering when using sculpt brush in drag dot mode.ClosedPublicActions