Hide ratio when using error margin mode in decimate keyframes operator
ClosedPublic
Actions

Authored by Colin Basnett (cmbasnett) on Oct 22 2022, 8:43 AM.

Details

Reviewers

Sybren A. Stüvel (sybren)

Commits

rBee5b6f715010: Hide ratio when using error margin mode in decimate keyframes operator

Summary

This fixes a bug in the function that determines what properties to show on the Decimate Keyframes operator.

Before the fix, the "Remove" (i.e., factor) slider was visible no matter what "Mode" was being used. This meant that the slider was visible and modifiable when it had no effect, creating confusion.

Before	After

Diff Detail

Repository

rB Blender

Branch

master

Build Status

Buildable 24380
Build 24380: arc lint + arc unit

Event Timeline

Colin Basnett (cmbasnett) requested review of this revision.Oct 22 2022, 8:43 AM

Colin Basnett (cmbasnett) created this revision.

Harbormaster completed remote builds in B24379: Diff 57040.Oct 22 2022, 8:43 AM

Renamed "Remove" slider to "Ratio" in decimate keyframes operator

Harbormaster completed remote builds in B24380: Diff 57041.Oct 22 2022, 8:51 AM

Colin Basnett (cmbasnett) edited the summary of this revision. (Show Details)Oct 22 2022, 8:57 AM

Colin Basnett (cmbasnett) added a reviewer: Sybren A. Stüvel (sybren).

Colin Basnett (cmbasnett) added a project: Animation & Rigging.

Colin Basnett (cmbasnett) edited the summary of this revision. (Show Details)Oct 22 2022, 9:20 AM

Sybren A. Stüvel (sybren) requested changes to this revision.Oct 22 2022, 10:08 AM

Sybren A. Stüvel (sybren) added inline comments.

source/blender/editors/space_graph/graph_slider_ops.c
535	This change should be in a different patch. Changing the label of this property is quite a different change than fixing when it'll show up. Also I don't think this change would be accepted, because "Remove" is more explicit -- a "remove" of 75% is clear, but a "ratio" of 75% is ambiguous (can be the same, but could also mean to keep 75%).

This revision now requires changes to proceed.Oct 22 2022, 10:08 AM

Revert "Renamed "Remove" slider to "Ratio" in decimate keyframes operator"

Harbormaster completed remote builds in B24383: Diff 57045.Oct 23 2022, 3:03 AM

Colin Basnett (cmbasnett) edited the summary of this revision. (Show Details)Nov 4 2022, 6:48 AM

Thanks!

This revision is now accepted and ready to land.Nov 8 2022, 10:44 AM

Closed by commit rBee5b6f715010: Hide ratio when using error margin mode in decimate keyframes operator (authored by Colin Basnett (cmbasnett)). · Explain WhyNov 9 2022, 12:31 AM

This revision was automatically updated to reflect the committed changes.

Colin Basnett (cmbasnett) marked an inline comment as done.

Colin Basnett (cmbasnett) added a commit: rBee5b6f715010: Hide ratio when using error margin mode in decimate keyframes operator.