Fix T102009: Panel are not displayed if Datablock is pinned
AbandonedPublic
Actions

Authored by Antonio Vazquez (antoniov) on Oct 23 2022, 1:51 PM.

Details

Reviewers

Pratik Borhade (PratikPB2123)
Philipp Oeser (lichtwerk)

Maniphest Tasks

T102009: Pin in GP data properties makes Layer specials button not display its options.

Diff Detail

Repository

rB Blender

Branch

temp-T102009 (branched from master)

Build Status

Buildable 24384
Build 24384: arc lint + arc unit

Event Timeline

Antonio Vazquez (antoniov) requested review of this revision.Oct 23 2022, 1:51 PM

Antonio Vazquez (antoniov) created this revision.

Harbormaster completed remote builds in B24384: Diff 57047.Oct 23 2022, 1:51 PM

@Pratik Borhade (PratikPB2123) This solve the issue, but I would like to hear your opinion before commit it.

Hi Antonio, your fix works well and make sense to me.
Only issue I found is in Vertex group panel. Expanding it is now possible but we still could not add or remove vertex groups (buttons are greyed out) when tab is pinned.

Maybe this can be handled as a separate issue.

This revision is now accepted and ready to land.Oct 24 2022, 10:41 AM

Dont think this is right, it would not show properties for the pinned data anymore? Active can be different from pinned, right? Or am i misunderstanding something?

This revision now requires changes to proceed.Oct 24 2022, 1:02 PM

Philipp Oeser (lichtwerk) mentioned this in T102009: Pin in GP data properties makes Layer specials button not display its options..Oct 24 2022, 1:42 PM

Antonio Vazquez (antoniov) abandoned this revision.Oct 24 2022, 4:02 PM