Page MenuHome
Differential D16322

Geometry Node: Dangling input in Viewer node
ClosedPublic
Actions

Authored by Iliya Katueshenock (Moder) on Oct 23 2022, 4:29 PM.

Details

Reviewers
Jacques Lucke (JacquesLucke)
Commits
rBfc544bc974e6: Fix: geometry nodes viewer shows black with dangling reroute input
Summary

Geometry Node: Dangling input in Viewer node

Dangling inputs should not produce a value.
Since the preview node runs in the implementation of the lazy function, it needs to do check this in the constructor.

BeforeAfter

Diff Detail

Event Timeline

Iliya Katueshenock (Moder) requested review of this revision.Oct 23 2022, 4:29 PM
Iliya Katueshenock (Moder) created this revision.
Iliya Katueshenock (Moder) edited the summary of this revision. (Show Details)Oct 23 2022, 6:08 PM
Jacques Lucke (JacquesLucke) added inline comments.Oct 23 2022, 7:02 PM
source/blender/nodes/intern/geometry_nodes_lazy_function.cc
530–531

It's a big weird to put all of that into the if condition. Can you simplify this code a bit?

Iliya Katueshenock (Moder) updated this revision to Diff 57053.Oct 23 2022, 7:06 PM
Iliya Katueshenock (Moder) marked an inline comment as done.

Old habit.

Jacques Lucke (JacquesLucke) accepted this revision.Oct 23 2022, 7:35 PM
This revision is now accepted and ready to land.Oct 23 2022, 7:35 PM
Closed by commit rBfc544bc974e6: Fix: geometry nodes viewer shows black with dangling reroute input (authored by Iliya Katueshenock (Moder), committed by Jacques Lucke (JacquesLucke)). · Explain WhyNov 12 2022, 2:19 PM
This revision was automatically updated to reflect the committed changes.
Jacques Lucke (JacquesLucke) added a commit: rBfc544bc974e6: Fix: geometry nodes viewer shows black with dangling reroute input.

Revision Contents
Changeset List

PathSize
source/
blender/
nodes/
intern/
3 lines

Diff 57053

View Options

source/blender/nodes/intern/geometry_nodes_lazy_function.cc

Loading...