Page MenuHome
Differential D16330

Sculpt: Fix crash with no active brush data-block
Needs ReviewPublic
Actions

Authored by Aaron Carlisle (Blendify) on Oct 24 2022, 8:25 PM.

Details

Reviewers
Joseph Eagar (joeedh)
Summary

Steps to reproduce:

From sculpt mode delete the brush users from the active tool and try to sculpt.

The fix is simple by just adding a null check to two functions.

Diff Detail

Repository
rB Blender
Branch
sculpt-fix-null-brush (branched from master)
Build Status
Buildable 24393
Build 24393: arc lint + arc unit

Event Timeline

Aaron Carlisle (Blendify) requested review of this revision.Oct 24 2022, 8:25 PM
Aaron Carlisle (Blendify) created this revision.
Harbormaster completed remote builds in B24393: Diff 57068.Oct 24 2022, 8:25 PM
Aaron Carlisle (Blendify) added a reviewer: Joseph Eagar (joeedh).Oct 24 2022, 8:27 PM
Aaron Carlisle (Blendify) added projects: BF Blender, Sculpt, Paint & Texture.
Aaron Carlisle (Blendify) retitled this revision from Sculpt: Fix crash when there is no active brush data-block to Sculpt: Fix crash with no active brush data-block.Oct 24 2022, 11:05 PM
Julien Kaspar (JulienKaspar) added a subscriber: Julien Kaspar (JulienKaspar).Nov 9 2022, 12:07 PM

@Joseph Eagar (joeedh) mentioned in the module meeting that he worked on a similar fix.
Joe can you comment on this further?

Joseph Eagar (joeedh) added a comment.Sat, Jan 14, 5:34 AM

I can't seem to reproduce this. Looks like it's no longer possible to assign null to a toolslot brush.

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
sculpt_paint/
8 lines

Diff 57068

View Options

source/blender/editors/sculpt_paint/sculpt.c

Loading...