This led to the color actually looking different on the node body itself
vs. in the panel, also using the colorpicker gave unexpected results.
Details
Details
- Reviewers
Brecht Van Lommel (brecht) Jacques Lucke (JacquesLucke) - Maniphest Tasks
- T99603: Node color is different from color panel
- Commits
- rB398de297cf52: Fix T99603: node body colors colormanagement issue
rBd2b74943ce01: Fix T99603: node body colors colormanagement issue
rBfb424db2b7bb: Fix T99603: node body colors colormanagement issue
Diff Detail
Diff Detail
- Repository
- rB Blender
- Branch
- T99603 (branched from master)
- Build Status
Buildable 24397 Build 24397: arc lint + arc unit
Event Timeline
Comment Actions
Hm, lets double-check if this fallback needs to rather check PROP_COLOR_GAMMA vs. PROP_COLOR instead...
https://developer.blender.org/diffusion/B/browse/master/source/blender/editors/interface/eyedroppers/eyedropper_color.c$361
Comment Actions
Even though the above still seems suspicious, excluding IMB_colormanagement_display_to_scene_linear_v3 in the case of just PROP_COLOR (as opposed to PROP_COLOR_GAMMA) only fixes half of the problem (panel displays the color seemingly correct, but then the node body itself displays too dark).
So while still on shaky ground, it still seems better to have the node body color be fully colormanaged for now (will let the experts decide).
Comment Actions
This is correct, UI colors should use PROP_COLOR_GAMMA to avoid being affected by scene color management.