Paths

Table of Contentst

Differential D16358

Flamenco Addon: Add an error message if the file is not saved before uploading
ClosedPublic
Actions

Authored by Yann Doersam (YetAnotherNiceName) on Nov 1 2022, 11:38 AM.

Tags

Subscribers

None

Details

Reviewers

Sybren A. Stüvel (sybren)

Maniphest Tasks

T102192: Flamenco Addon: Python error when uploading file to Flamenco

Commits

rF1cef0d48df79: Addon: Show error if the file path is not known before submitting

Summary

If file is not saved, Flamenco cannot create a temp copy, which it will render.
See (T102192)

Diff Detail

Repository

Branch

T102192-Add-Error-unsaved (branched from main)

Build Status

Buildable 24444
Build 24444: arc lint + arc unit

Event Timeline

Yann Doersam (YetAnotherNiceName) requested review of this revision.Nov 1 2022, 11:38 AM

Yann Doersam (YetAnotherNiceName) created this revision.

Harbormaster completed remote builds in B24444: Diff 57166.Nov 1 2022, 11:38 AM

Yann Doersam (YetAnotherNiceName) retitled this revision from Flamenco Addon: Add an error message if the file is not saved before uploading it to Flamenco (T102192) to Flamenco Addon: Add an error message if the file is not saved before uploading.Nov 1 2022, 11:39 AM

Yann Doersam (YetAnotherNiceName) edited the summary of this revision. (Show Details)

Yann Doersam (YetAnotherNiceName) added a project: Flamenco.

Thanks for the patch!

I'll adjust it a little bit before I commit it. The most important difference is that I'll replace if not bpy.data.is_saved: with if not context.blend_data.filepath:. The purpose of having the add-on save to a separate .flamenco.blend file is to allow submitting different variations of a file (for example to try out different shaders) without ever overwriting the original.

Check for the filename being known, rather than the file being saved
Slight change in wording ("sending to" → "submitting")

Harbormaster completed remote builds in B24531: Diff 57340.Nov 8 2022, 11:44 AM

Sybren A. Stüvel (sybren) accepted this revision.Nov 8 2022, 11:45 AM

This revision is now accepted and ready to land.Nov 8 2022, 11:45 AM

Closed by commit rF1cef0d48df79: Addon: Show error if the file path is not known before submitting (authored by Yann Doersam (YetAnotherNiceName), committed by Sybren A. Stüvel (sybren)). · Explain WhyNov 8 2022, 11:49 AM

This revision was automatically updated to reflect the committed changes.

Sybren A. Stüvel (sybren) added a commit: rF1cef0d48df79: Addon: Show error if the file path is not known before submitting.

Revision Contents
Changeset List

Path

Size

addon/

flamenco/

5 lines

Diff 57166

addon/flamenco/operators.py

Loading...