Page MenuHome

Flamenco Addon: Add an error message if the file is not saved before uploading
ClosedPublic

Authored by Yann Doersam (YetAnotherNiceName) on Nov 1 2022, 11:38 AM.

Details

Summary

If file is not saved, Flamenco cannot create a temp copy, which it will render.
See (T102192)

Diff Detail

Repository
rF Flamenco
Branch
arcpatch-D16358 (branched from main)
Build Status
Buildable 24531
Build 24531: arc lint + arc unit

Event Timeline

Yann Doersam (YetAnotherNiceName) created this revision.
Yann Doersam (YetAnotherNiceName) retitled this revision from Flamenco Addon: Add an error message if the file is not saved before uploading it to Flamenco (T102192) to Flamenco Addon: Add an error message if the file is not saved before uploading.Nov 1 2022, 11:39 AM
Yann Doersam (YetAnotherNiceName) edited the summary of this revision. (Show Details)

Thanks for the patch!

I'll adjust it a little bit before I commit it. The most important difference is that I'll replace if not bpy.data.is_saved: with if not context.blend_data.filepath:. The purpose of having the add-on save to a separate .flamenco.blend file is to allow submitting different variations of a file (for example to try out different shaders) without ever overwriting the original.

  • Check for the filename being known, rather than the file being saved
  • Slight change in wording ("sending to" → "submitting")
This revision is now accepted and ready to land.Nov 8 2022, 11:45 AM