Page MenuHome
Differential D16362

Cleanup: Improve precision during UV packing.
ClosedPublic
Actions

Authored by Chris Blackbourn (chrisbblend) on Nov 2 2022, 12:25 AM.

Details

Reviewers
Campbell Barton (campbellbarton)
Commits
rBc6aacd718a51: Cleanup: Improve precision during UV packing.
Summary

Simplify API and improve algorithm and precision for uv packing algorithms.
Protects against future precision problems with UDIM.




No user visible changes expected.






Maniphest Tasks T68889
Diff Detail
Repository 
rB Blender 
Event Timeline
Chris Blackbourn (chrisbblend) requested review of this revision.Nov 2 2022, 12:25 AM
Chris Blackbourn (chrisbblend) created this revision.
Campbell Barton (campbellbarton) accepted this revision.Nov 8 2022, 6:16 AM
Accepting with minor requests.
source/blender/editors/uvedit/uvedit_islands.cc


792
This code isn't as obviously rotating around a pivot (as it was before), it would be good to note whats being done on a user level.


794–797
It looks like matrix and matrix_inverse are being created for every island unnecessarily.
This revision is now accepted and ready to land.Nov 8 2022, 6:16 AM
Campbell Barton (campbellbarton) added a comment.Nov 8 2022, 6:17 AM
Reminder to make the commit log a summary of what the change is and why.
Closed by commit rBc6aacd718a51: Cleanup: Improve precision during UV packing. (authored by Chris Blackbourn (chrisbblend)).  ·  Explain WhyNov 8 2022, 8:53 PM
This revision was automatically updated to reflect the committed changes.
Chris Blackbourn (chrisbblend) marked an inline comment as done.
Chris Blackbourn (chrisbblend) added a commit: rBc6aacd718a51: Cleanup: Improve precision during UV packing..
Revision Contents
Changeset List
PathSize
source/
blender/
bmesh/
intern/
1 line
11 lines
editors/
uvedit/
88 lines
Diff 57183
View Options
source/blender/bmesh/intern/bmesh_query_uv.h
Loading...
View Options
source/blender/bmesh/intern/bmesh_query_uv.cc
Loading...
View Options
source/blender/editors/uvedit/uvedit_islands.cc
Loading...