Page MenuHome
Differential D16374

Manual: version switch modernization
ClosedPublic
Actions

Authored by Tobias Heinke (TobiasH) on Nov 3 2022, 4:51 AM.

Details

Reviewers
Aaron Carlisle (Blendify)
Commits
rBM9683: version switch: modernize
Summary

class, promise, template tag, let/const (only for new for now)

Should we drop jQuery already to plain JS?

  • json: fetch api
  • animation: .animate()
  • querySelector, toggle eventlistner,...

Diff Detail

Repository
rBM Blender Manual

Event Timeline

Tobias Heinke (TobiasH) requested review of this revision.Nov 3 2022, 4:51 AM
Tobias Heinke (TobiasH) created this revision.
Aaron Carlisle (Blendify) added a comment.Nov 3 2022, 5:01 AM

Should we drop jQuery already to plain JS?

Yes especially since sphinx itself will be dropping jQuary in Sphinx6 so this will be preventing us from upgrading unless we include it ourselves.

This revision was not accepted when it landed; it landed in state Needs Review.Nov 8 2022, 1:52 AM
Closed by commit rBM9683: version switch: modernize (authored by Tobias Heinke (TobiasH)). · Explain Why
This revision was automatically updated to reflect the committed changes.
Tobias Heinke (TobiasH) added a commit: rBM9683: version switch: modernize.

Revision Contents
Changeset List

PathSize
resources/
templates/
17 lines
theme/
js/
170 lines

Diff 57214

View Options

resources/templates/versions.html

Loading...
View Options

resources/theme/js/version_switch.js

Loading...