Cycles: Remove use of sprintf() in MD5 code
ClosedPublic
Actions

Authored by Sergey Sharybin (sergey) on Nov 3 2022, 3:10 PM.

Details

Reviewers

Brecht Van Lommel (brecht)

Commits

rB74c293863ded: Cycles: Remove use of sprintf() in MD5 code

Summary

The new Xcode declares the sprintf() function deprecated and
suggests to sue snprintf() as a safer alternative.

This change actually moves away from any formatted printing and
uses inlined byte-to-hex-string conversion which is also safe
and is (unmesurably) faster.

Diff Detail

Repository: rB Blender

Event Timeline

Sergey Sharybin (sergey) requested review of this revision.Nov 3 2022, 3:10 PM

Sergey Sharybin (sergey) created this revision.

Harbormaster completed remote builds in B24473: Diff 57224.Nov 3 2022, 3:10 PM

Brecht Van Lommel (brecht) accepted this revision.Nov 3 2022, 3:14 PM

This revision is now accepted and ready to land.Nov 3 2022, 3:14 PM

Closed by commit rB74c293863ded: Cycles: Remove use of sprintf() in MD5 code (authored by Sergey Sharybin (sergey)). · Explain WhyNov 3 2022, 3:15 PM

This revision was automatically updated to reflect the committed changes.

Sergey Sharybin (sergey) added a commit: rB74c293863ded: Cycles: Remove use of sprintf() in MD5 code.

Revision Contents
Changeset List

Path

Size

intern/

cycles/

util/

md5.cpp

9 lines

Diff 57225

View Options

intern/cycles/util/md5.cpp

Cycles: Remove use of sprintf() in MD5 codeClosedPublicActions