adding defaults for NLA Action scale and repeat
ClosedPublic
Actions

Authored by Nate Rupsis (nrupsis) on Nov 3 2022, 3:19 PM.

Details

Reviewers

Sybren A. Stüvel (sybren)
Brad Clark (RiggingDojo)

Commits

rB0e0b3d6e1a00: adding defaults for NLA Action scale and repeat

Summary

Previously when defaulting out an actions clip Scale and Repeat value, there was no default value set. Thus 0 was used as a default, which caused the lower bounds clap value (0.0001 & 0.01) to be used instead

This patch adds default values of 1.0f to both Action Clip "Scale" & "Repeat"

Diff Detail

Repository

rB Blender

Branch

nla_defaults (branched from master)

Build Status

Buildable 24474
Build 24474: arc lint + arc unit

Event Timeline

Nate Rupsis (nrupsis) requested review of this revision.Nov 3 2022, 3:19 PM

Nate Rupsis (nrupsis) created this revision.

Harbormaster completed remote builds in B24474: Diff 57226.Nov 3 2022, 3:19 PM

Nate Rupsis (nrupsis) edited the summary of this revision. (Show Details)Nov 3 2022, 3:23 PM

Nate Rupsis (nrupsis) added 1 blocking reviewer(s): Sybren A. Stüvel (sybren).Nov 3 2022, 3:39 PM

... the lower bounds clap value

Someone here is in a slapping mood :)

Also, you made the default value the default value, brilliant!

This revision is now accepted and ready to land.Nov 3 2022, 4:27 PM

PS: I think this is a bugfix, and should go into the blender-v3.4-release stabilizing branch.

Closed by commit rB0e0b3d6e1a00: adding defaults for NLA Action scale and repeat (authored by Nate Rupsis (nrupsis)). · Explain WhyNov 3 2022, 6:19 PM

This revision was automatically updated to reflect the committed changes.

Nate Rupsis (nrupsis) added a commit: rB0e0b3d6e1a00: adding defaults for NLA Action scale and repeat.

Revision Contents
Changeset List

Path

Size

source/

blender/

makesrna/

intern/

rna_nla.c

2 lines

Diff 57226

View Options

source/blender/makesrna/intern/rna_nla.c

adding defaults for NLA Action scale and repeatClosedPublicActions