Page MenuHome
Differential D16383

UI: Sort items in Weight Locks menu
ClosedPublic
Actions

Authored by Pablo Vazquez (pablovazquez) on Nov 4 2022, 2:20 AM.

Details

Reviewers
Julian Eisel (Severin)
Commits
rB28e952dacd83: UI: Sort items in Weight Locks menu
Summary

Reorder the items in the Locks menu:

  • Split into three groups: Lock, Unlock, Invert.
  • Use icon only in the first item of each group.

Master:

Patch:

Diff Detail

Repository
rB Blender
Branch
ui-weight-locks-menu (branched from master)
Build Status
Buildable 24481
Build 24481: arc lint + arc unit

Event Timeline

Pablo Vazquez (pablovazquez) requested review of this revision.Nov 4 2022, 2:20 AM
Pablo Vazquez (pablovazquez) created this revision.
Harbormaster completed remote builds in B24481: Diff 57238.Nov 4 2022, 2:20 AM
Pablo Vazquez (pablovazquez) edited the summary of this revision. (Show Details)Nov 4 2022, 2:24 AM
Pablo Vazquez (pablovazquez) added a project: User Interface.
Pablo Vazquez (pablovazquez) added a reviewer: Julian Eisel (Severin).Nov 4 2022, 2:28 AM
Pablo Vazquez (pablovazquez) added a subscriber: Julian Eisel (Severin).

Having icons in the first item of a group is an unwritten rule that we should probably add to the HIG. Should it go under Layout or a new Menu section, what do you think @Julian Eisel (Severin)?

Julian Eisel (Severin) accepted this revision.Nov 5 2022, 7:35 PM
In D16383#446007, @Pablo Vazquez (pablovazquez) wrote:

Having icons in the first item of a group is an unwritten rule that we should probably add to the HIG. Should it go under Layout or a new Menu section, what do you think @Julian Eisel (Severin)?

Would add a menu section, makes the information easier to find since it’s more concrete.

This revision is now accepted and ready to land.Nov 5 2022, 7:35 PM
Pablo Vazquez (pablovazquez) updated this revision to Diff 57288.Nov 6 2022, 2:26 AM
In D16383#446325, @Julian Eisel (Severin) wrote:

Would add a menu section, makes the information easier to find since it’s more concrete.

Thanks, done! Added example to the HIG

Harbormaster completed remote builds in B24501: Diff 57288.Nov 6 2022, 2:26 AM
Closed by commit rB28e952dacd83: UI: Sort items in Weight Locks menu (authored by Pablo Vazquez (pablovazquez)). · Explain WhyNov 6 2022, 2:29 AM
This revision was automatically updated to reflect the committed changes.
Pablo Vazquez (pablovazquez) added a commit: rB28e952dacd83: UI: Sort items in Weight Locks menu.

Revision Contents
Changeset List

PathSize
release/
scripts/
startup/
bl_ui/
30 lines

Diff 57238

View Options

release/scripts/startup/bl_ui/space_view3d.py

Loading...