Page MenuHome
Differential D16396

Geometry Nodes: Rename Transform node to Transform Geometry
ClosedPublic
Actions

Authored by Iliya Katueshenock (Moder) on Nov 5 2022, 2:16 PM.

Details

Reviewers
Hans Goudey (HooglyBoogly)
Jacques Lucke (JacquesLucke)
Commits
rB42485b01d2a2: Geometry Nodes: Rename Transform node to Transform Geometry
Summary

Change name to make navigation easier for beginner users.
This should more clearly hint at the direction of this node to change the full geometry, and not work with fields.

Diff Detail

Repository
rB Blender

Event Timeline

Iliya Katueshenock (Moder) requested review of this revision.Nov 5 2022, 2:16 PM
Iliya Katueshenock (Moder) updated this revision to Diff 57274.
Iliya Katueshenock (Moder) created this revision.
  • Commetst with patch id
Iliya Katueshenock (Moder) updated this revision to Diff 57275.Nov 5 2022, 2:18 PM
  • Format
Iliya Katueshenock (Moder) added a parent revision: D16394: Geometry Node: Collection Info: Change output socket name to Instances.Nov 5 2022, 2:19 PM
Iliya Katueshenock (Moder) retitled this revision from Geometry Node: Reanme Transfomt node to Transfromt Geometry to Geometry Node: Rename Transfomt node to Transfromt Geometry.
Iliya Katueshenock (Moder) edited the summary of this revision. (Show Details)
Hans Goudey (HooglyBoogly) retitled this revision from Geometry Node: Rename Transfomt node to Transfromt Geometry to Geometry Nodes: Rename Transform node to Transform Geometry.Nov 6 2022, 10:31 AM
Hans Goudey (HooglyBoogly) edited the summary of this revision. (Show Details)
Iliya Katueshenock (Moder) added inline comments.Nov 18 2022, 7:38 PM
source/blender/blenloader/intern/versioning_300.cc
3685 ↗(On Diff #57275)

Does it mean to keep this old name for python compatibility?

Hans Goudey (HooglyBoogly) added inline comments.Nov 18 2022, 7:47 PM
source/blender/blenloader/intern/versioning_300.cc
3685 ↗(On Diff #57275)

Yeah, it would mean this patch wouldn't require any versioning AFAIK

Iliya Katueshenock (Moder) planned changes to this revision.Nov 19 2022, 5:05 PM
Iliya Katueshenock (Moder) removed a parent revision: D16394: Geometry Node: Collection Info: Change output socket name to Instances.
Iliya Katueshenock (Moder) updated this revision to Diff 57826.Nov 19 2022, 5:58 PM

Maintained API compatibility.

Hans Goudey (HooglyBoogly) accepted this revision.Nov 21 2022, 5:58 PM
This revision is now accepted and ready to land.Nov 21 2022, 5:58 PM
Jacques Lucke (JacquesLucke) accepted this revision.Nov 23 2022, 5:28 PM
Closed by commit rB42485b01d2a2: Geometry Nodes: Rename Transform node to Transform Geometry (authored by Iliya Katueshenock (Moder), committed by Hans Goudey (HooglyBoogly)). · Explain WhyNov 27 2022, 1:13 AM
This revision was automatically updated to reflect the committed changes.
Hans Goudey (HooglyBoogly) added a commit: rB42485b01d2a2: Geometry Nodes: Rename Transform node to Transform Geometry.
Iliya Katueshenock (Moder) mentioned this in D16628: Docs: Geometry Node: Transform to Transform Geometry.Nov 27 2022, 4:33 AM

Revision Contents
Changeset List

PathSize
source/
blender/
blenkernel/
2 lines
nodes/
2 lines
geometry/
2 lines
2 lines
2 lines
nodes/
node_geo_transform_geometry.cc
node_geo_transform.cc
11 lines

Diff 58067

View Options

source/blender/blenkernel/BKE_node.h

Loading...
View Options

source/blender/nodes/NOD_static_types.h

Loading...
View Options

source/blender/nodes/geometry/CMakeLists.txt

Loading...
View Options

source/blender/nodes/geometry/node_geometry_register.hh

Loading...
View Options

source/blender/nodes/geometry/node_geometry_register.cc

Loading...
View Options

source/blender/nodes/geometry/nodes/node_geo_transform.cc

Loading...
View Options

source/blender/nodes/geometry/nodes/node_geo_transform_geometry.cc

Loading...