Fix: OpenSubdiv reporting version 0.0.0 in system_info.txt
ClosedPublic
Actions

Authored by Ray Molenkamp (LazyDodo) on Nov 5 2022, 5:18 PM.

Details

Reviewers

Brecht Van Lommel (brecht)

Commits

rB1b34da5da639: Fix: OpenSubdiv reporting version 0.0.0 in system_info.txt

Summary

Unsure when this started but when you generate the system_info report, it has this section

Other Libraries:
==========================================

OpenColorIO:  2,  1,  1
OpenImageIO:  2,  3, 20
OpenShadingLanguage:  1, 12,  6
OpenSubdiv:  0,  0,  0
OpenVDB:  9,  0,  0
Alembic:  1,  8,  3
USD:  0, 22,  3

OSD Lists as 0, 0, 0 this is due to opensubdiv_capi.cc not actually including the OSD version header, so it's not getting the version define, and the code in openSubdiv_getVersionHex is really well prepared to deal with any or no version at all of OSD, catches the problem and returns 0, 0, 0

Given this file is only build when OSD is enabled we can just blindly include OpenSubdiv/version.h here