Paths

Table of Contentst

Differential D16410

Fix deprecation warnings about printf() on macOS
ClosedPublic
Actions

Authored by Sergey Sharybin (sergey) on Nov 7 2022, 3:47 PM.

Tags

None

Subscribers

None

Details

Reviewers

Brecht Van Lommel (brecht)

Commits

rB0d945fe20e87: Fix deprecation warnings about printf() on macOS

Summary

The new Xcode 14.1 brings the new Apple Clang compiler which
considers sprintf unsafe and geenrates deprecation warnings
suggesting to sue snprintf instead. This only happens for C++
code by default, and C code can still use sprintf without any
warning.

This changes does the following:

Whenever is trivial replace sprintf() with BLI_snprintf.
For all other cases use the newly introduced BLI_sprintf which is a wrapper around sprintf() but without warning.

There is a discouragement note in the BLI_sprintf comment to
suggest use of BLI_snprintf when the size is known.

Diff Detail

Repository

Branch

sprintf (branched from master)

Build Status

Buildable 24517
Build 24517: arc lint + arc unit

Event Timeline

Sergey Sharybin (sergey) requested review of this revision.Nov 7 2022, 3:47 PM

Sergey Sharybin (sergey) created this revision.

Harbormaster completed remote builds in B24517: Diff 57320.Nov 7 2022, 3:47 PM

Sergey Sharybin (sergey) added a reviewer: Brecht Van Lommel (brecht).Nov 7 2022, 5:25 PM

I assume this will be committed to blender-v3.4-release? And maybe even backported to 3.3 and 2.93.

This revision is now accepted and ready to land.Nov 7 2022, 8:49 PM

This is where I am actually on a split. The patch is against the master branch, but it should be easy to apply to 3.4.
On one hand it is not really a fix, but on another hand it will help catching real issues in the compiler logs when working in the 3.4 branch. If you think it is safe and good for 3.4 lets do it!

Closed by commit rB0d945fe20e87: Fix deprecation warnings about printf() on macOS (authored by Sergey Sharybin (sergey)). · Explain WhyNov 8 2022, 12:03 PM

This revision was automatically updated to reflect the committed changes.

Sergey Sharybin (sergey) added a commit: rB0d945fe20e87: Fix deprecation warnings about printf() on macOS.

Revision Contents
Changeset List

Path

Size

source/

blender/

blenkernel/

intern/

2 lines

4 lines

6 lines

6 lines

2 lines

blenlib/

7 lines

intern/

4 lines

15 lines

27 lines

14 lines

blenloader/

intern/

13 lines

compositor/

intern/

2 lines

draw/

intern/

draw_manager_profiling.c

48 lines

2 lines

editors/

io/

2 lines

object/

object_bake_api.c

2 lines

object_constraint.c

4 lines

render/

render_internal.cc

25 lines

render_preview.cc

8 lines

space_node/

2 lines

space_outliner/

tree/

tree_element_rna.cc

7 lines

space_view3d/

14 lines

io/

avi/

intern/

6 lines

collada/

AnimationExporter.cpp

3 lines

GeometryExporter.cpp

2 lines

gpencil/

intern/

gpencil_io_export_svg.cc

7 lines

makesrna/

intern/

4 lines

nodes/

texture/

nodes/

node_texture_output.c

2 lines

python/

bmesh/

bmesh_py_types.c

9 lines

intern/

2 lines

sequencer/

intern/

20 lines

Diff 57320

source/blender/blenkernel/intern/freestyle.c

Loading...

source/blender/blenkernel/intern/image.cc

Loading...

source/blender/blenkernel/intern/node.cc

Loading...

source/blender/blenkernel/intern/pointcache.c

Loading...

source/blender/blenkernel/intern/writeffmpeg.c

Loading...

source/blender/blenlib/BLI_string.h

Loading...

source/blender/blenlib/intern/path_util.c

Loading...

source/blender/blenlib/intern/string.c

Loading...

source/blender/blenlib/intern/uuid.cc

Loading...

source/blender/blenlib/intern/winstuff.c

Loading...

source/blender/blenloader/intern/writefile.cc

Loading...

source/blender/compositor/intern/COM_Debug.cc

Loading...

source/blender/draw/intern/draw_manager_profiling.c

Loading...

source/blender/draw/intern/draw_pbvh.cc

Loading...

source/blender/editors/io/io_collada.c

Loading...

source/blender/editors/object/object_bake_api.c

Loading...

source/blender/editors/object/object_constraint.c

Loading...

source/blender/editors/render/render_internal.cc

Loading...

source/blender/editors/render/render_preview.cc

Loading...

source/blender/editors/space_node/space_node.cc

Loading...

source/blender/editors/space_outliner/tree/tree_element_rna.cc

Loading...

source/blender/editors/space_view3d/view3d_draw.cc

Loading...

source/blender/io/avi/intern/avi_codecs.c

Loading...

source/blender/io/collada/AnimationExporter.cpp

Loading...

source/blender/io/collada/GeometryExporter.cpp

Loading...

source/blender/io/gpencil/intern/gpencil_io_export_svg.cc

Loading...

source/blender/makesrna/intern/rna_particle.c

Loading...

source/blender/nodes/texture/nodes/node_texture_output.c

Loading...

source/blender/python/bmesh/bmesh_py_types.c

Loading...

source/blender/python/intern/bpy_rna.c

Loading...

source/blender/sequencer/intern/disk_cache.c

Loading...