Joe added a temp debug visualizing, which we agreed should stay for the final feature in a simplified form.
A needed addition is to visualize the samples curve already on stroke start.
The stroke curve will also be changed into single color for simplicity.

New optimization strategy for spline texture mapping.
Implemented a quadratic bezier backend. It didn't prove as useful as I thought, will be removed unless there's a use for it.

Harbormaster completed remote builds in B24680: Diff 57723.Nov 17 2022, 9:45 AM

Okay something has gone wrong here.

Fix broken patch

Harbormaster completed remote builds in B24681: Diff 57724.Nov 17 2022, 10:03 AM

Update to latest version and sync with master.

Harbormaster completed remote builds in B25086: Diff 58716.Dec 18 2022, 2:47 PM

Joseph Eagar (joeedh) added a reviewer: Brecht Van Lommel (brecht).Dec 18 2022, 2:47 PM

I'll add myself as a reviewer. I'll test the patch again soon for usability.

Some notes from testing this and reading other users feedback. These are the most important to tackle if we want to commit before bcon2.

There are still plenty of artifacts, both between the split texture steps, and circular brush falloff artifacts. (The effects are more visible when using sphere or constant falloff)

I know the current overlay for the stroke was made for debugging. But we should keep using this only while the stroke is not applied yet, like the Stabilize Stroke setting.

By using the same line thickness and color, having both combined should blend nicely together.
After the stroke starts being applied, the overlay should disappear, and only reappear if a new stroke needs to be calculated.

Enabling the Rake setting in other texture mapping modes is messing up the Roll method.

Continuing a stroke beyond the boundaries of the mesh will result in issues.

The stroke is never properly concluded up to the boundary.
Once the stroke continues on the mesh the stroke will jump to that point instead of starting anew.

Performance is also quite a lot slower than regular textured strokes. Even a slower stroke does not fully help avoiding this
This should be fixed, or at least optimized after committing to master.

This revision now requires changes to proceed.Dec 22 2022, 5:36 PM

It's also good too note that there will always be a fade in and out for the textured stroke.
Can this be improved somehow by making sure the strength is applied differently for this method?

Also, there should maybe be something to prevent using this texture method with certain stroke methods. Dots should not be combined with Roll.

Draw curve line at stroke start only.
Fix dash mode.

Harbormaster completed remote builds in B25179: Diff 58967.Dec 31 2022, 12:14 AM

I'd like to review this too, particularly the way the code interacts with the new curve evaluation code. Generally I think the Bezier / even spline code should reuse and improve the existing lower level curve evaluation and parameterization code. I can make that feedback more specific later though.

paint_stroke.c should me moved to C++ in a separate commit (as described in T103343).

Sync with master
Fix rotation bug.
Fix inproper application of rake flag

Harbormaster completed remote builds in B25206: Diff 59043.Jan 3 2023, 7:36 PM

Some quick superficial comments, did not look at this closely yet.

source/blender/editors/sculpt_paint/paint_stroke.cc
98	Can you add a comment explaining the difference between samples and points?
173	There is no clear relation between this logic and `PAINT_MAX_INPUT_SAMPLES`. I think things should be structured in such a way that it's obvious there is enough space in the array.
source/blender/editors/sculpt_paint/sculpt_intern.h
562	This doesn't seem to be used.
563	This is set but not read anywhere?

Removing myself as reviewer from sculpt patches since this is not my responsibility and I don't have enough time for it. If it's unclear who should review it can be worked out with Dalai or Thomas.

@Hans Goudey (HooglyBoogly) You want to still elaborate on your review?

@Joseph Eagar (joeedh) I tested the patch again most issues I mentioned above are still present:

In D16414#458544, @Julien Kaspar (JulienKaspar) wrote:

Some notes from testing this and reading other users feedback. These are the most important to tackle if we want to commit before bcon2.

There are still plenty of artifacts, both between the split texture steps, and circular brush falloff artifacts. (The effects are more visible when using sphere or constant falloff)

I know the current overlay for the stroke was made for debugging. But we should keep using this only while the stroke is not applied yet, like the Stabilize Stroke setting.

By using the same line thickness and color, having both combined should blend nicely together.
After the stroke starts being applied, the overlay should disappear, and only reappear if a new stroke needs to be calculated.

Continuing a stroke beyond the boundaries of the mesh will result in issues.

The stroke is never properly concluded up to the boundary.
Once the stroke continues on the mesh the stroke will jump to that point instead of starting anew.

Using the Painting brushes also causes a crash now or won't result in any visual changes and quite poor performance.

@Hans Goudey (HooglyBoogly) You want to still elaborate on your review?

It's really more of a conversation that needs to be had. I feel strongly that we shouldn't add another implementation of curve evaluation and arc length parameterization. Adding a helper class to combine data storage as an abstraction for sculpt mode is reasonable, but the implementation should be shared.
If the existing curve/Bezier code needs to be changed to accommodate that I would absolutely help out.

There are also Brecht's comments and moving the file to C++ separately in master.

In D16414#465635, @Hans Goudey (HooglyBoogly) wrote:

@Hans Goudey (HooglyBoogly) You want to still elaborate on your review?

It's really more of a conversation that needs to be had. I feel strongly that we shouldn't add another implementation of curve evaluation and arc length parameterization. Adding a helper class to combine data storage as an abstraction for sculpt mode is reasonable, but the implementation should be shared.
If the existing curve/Bezier code needs to be changed to accommodate that I would absolutely help out.

There are also Brecht's comments and moving the file to C++ separately in master.

I don't care where the low-level code lives. I did find the existing arc length parameterization code to be pretty unusable.

Sync with master and fix crash in paint brush

Harbormaster completed remote builds in B25546: Diff 59870.Tue, Jan 24, 5:55 PM

Julien Kaspar (JulienKaspar) edited the summary of this revision. (Show Details)Wed, Jan 25, 4:40 PM

Revision Contents
Changeset List

Path

Size

build_files/

build_environment/

install_deps.sh

10 lines

intern/

cycles/

CMakeLists.txt

33 lines

device/

CMakeLists.txt

29 lines

denoise.h

20 lines

device.h

15 lines

metal/

6 lines

3 lines

8 lines

53 lines

optix/

device_impl.h

80 lines

device_impl.cpp

776 lines

integrator/

4 lines

2 lines

52 lines

	denoiser_gpu.cpp
	denoiser_device.cpp

33 lines

denoiser_optix.h

72 lines

denoiser_optix.cpp

773 lines

kernel/

data_template.h

4 lines

device/

metal/

bvh.h

19 lines

kernel.metal

41 lines

film/

adaptive_sampling.h

22 lines

scene/

object.cpp

13 lines

ghost/

CMakeLists.txt

5 lines

intern/

GHOST_SystemWayland.h

56 lines

GHOST_SystemWayland.cpp

583 lines

GHOST_WindowWayland.h

26 lines

GHOST_WindowWayland.cpp

677 lines

opensubdiv/

internal/

base/

opensubdiv_capi.cc

2 lines

wayland_dynload/

extern/

wayland_dynload_client.h

19 lines

release/

scripts/

modules/

bl_i18n_utils/

bl_extract_messages.py

2 lines

settings.py

1 line

utils_spell_check.py

2 lines

rna_keymap_ui.py

5 lines

startup/

bl_operators/

wm.py

19 lines

bl_ui/

node_add_menu_geometry.py

1 line

properties_paint_common.py

3 lines

space_clip.py

28 lines

space_image.py

5 lines

space_view3d.py

6 lines

source/

blender/

CMakeLists.txt

1 line

	asset_system/
	blenkernel/

	AS_asset_catalog.hh
	BKE_asset_catalog.hh

12 lines

	AS_asset_catalog_path.hh
	BKE_asset_catalog_path.hh

10 lines

	AS_asset_library.h
	BKE_asset_library.h

12 lines

	AS_asset_library.hh
	BKE_asset_library.hh

31 lines

	AS_asset_representation.hh
	BKE_asset_representation.hh

6 lines

intern/

asset_catalog.cc

16 lines

asset_catalog_path.cc

8 lines

asset_library.cc

63 lines

asset_library_service.hh

12 lines

asset_library_service.cc

13 lines

asset_representation.cc

28 lines

	tests/
	intern/

asset_catalog_path_test.cc

6 lines

asset_catalog_test.cc

7 lines

asset_library_service_test.cc

4 lines

asset_library_test.cc

22 lines

asset_system/

AS_asset_representation.h

28 lines

CMakeLists.txt

51 lines

blenkernel/

BKE_asset.h

10 lines

BKE_asset_catalog.hh

BKE_asset_catalog_path.hh

BKE_asset_library.h

BKE_asset_library.hh

BKE_asset_representation.hh

20 lines

2 lines

16 lines

15 lines

3 lines

5 lines

1 line

1 line

25 lines

intern/

asset_catalog.cc

asset_catalog_path.cc

asset_catalog_path_test.cc

asset_catalog_test.cc

asset_library.cc

asset_library_service.hh

asset_library_service.cc

asset_library_service_test.cc

asset_library_test.cc

	asset_metadata_test.cc
	asset_test.cc

54 lines

asset_representation.cc

asset_test.cc

bvhutils.cc

444 lines

cloth.c

	cloth.cc
	cloth.c

193 lines

48 lines

3 lines

4 lines

5 lines

14 lines

3 lines

4 lines

5 lines

6 lines

4 lines

4 lines

412 lines

	mesh_remap.cc
	mesh_remap.c

222 lines

nla.c

11 lines

node.cc

1 line

shrinkwrap.cc

13 lines

blenlib/

5 lines

27 lines

16 lines

44 lines

BLI_cpp_types_make.hh

29 lines

BLI_disjoint_set.hh

38 lines

BLI_even_spline.hh

1397 lines

BLI_listbase_wrapper.hh

2 lines

BLI_math_vec_types.hh

1 line

BLI_parameter_pack_utils.hh

7 lines

CMakeLists.txt

4 lines

intern/

cpp_type.cc

cpp_types.cc

98 lines

tests/

BLI_cpp_type_test.cc

2 lines

blenloader/

intern/

readfile.cc

2 lines

versioning_300.cc

46 lines

bmesh/

CMakeLists.txt

2 lines

bmesh.h

8 lines

bmesh_class.h

8 lines

intern/

bmesh_callback_generic.h

8 lines

8 lines

8 lines

8 lines

8 lines

8 lines

8 lines

20 lines

	bmesh_iterators.cc
	bmesh_iterators.c

30 lines

8 lines

8 lines

8 lines

8 lines

8 lines

bmesh_mesh_duplicate.h

8 lines

bmesh_mesh_normals.h

8 lines

bmesh_mesh_partial_update.h

8 lines

bmesh_mesh_tessellate.h

8 lines

bmesh_mesh_validate.h

8 lines

bmesh_mods.h

8 lines

bmesh_operators.h

8 lines

bmesh_polygon.h

8 lines

bmesh_polygon_edgenet.h

8 lines

bmesh_query.h

8 lines

bmesh_query_uv.h

8 lines

bmesh_walkers.h

8 lines

tools/

bmesh_bevel.c

7 lines

draw/

engines/

overlay/

overlay_engine.cc

4 lines

intern/

DRW_gpu_wrapper.hh

17 lines

draw_cache_extract_mesh_render_data.cc

4 lines

25 lines

32 lines

7 lines

2 lines

52 lines

4 lines

39 lines

96 lines

76 lines

shaders/

common_view_lib.glsl

2 lines

draw_command_generate_comp.glsl

40 lines

draw_view_info.hh

11 lines

draw_visibility_comp.glsl

33 lines

editors/

animation/

anim_channels_edit.c

13 lines

anim_filter.c

2 lines

asset/

CMakeLists.txt

1 line

ED_asset_catalog.hh

23 lines

intern/

34 lines

9 lines

4 lines

26 lines

interface/

CMakeLists.txt

1 line

interface_templates.c

66 lines

view2d_gizmo_navigate.cc

7 lines

sculpt_paint/

CMakeLists.txt

2 lines

paint_intern.h

24 lines

paint_stroke.c

	paint_stroke.cc
	paint_stroke.c

485 lines

sculpt.cc

62 lines

sculpt_intern.h

2 lines

sculpt_ops.c

152 lines

space_file/

CMakeLists.txt

1 line

asset_catalog_tree_view.cc

15 lines

file_intern.h

4 lines

filelist.cc

16 lines

space_nla/

nla_select.c

20 lines

space_node/

1 line

77 lines

5 lines

5 lines

space_outliner/

outliner_tools.cc

5 lines

transform/

transform_snap_object.cc

22 lines

util/

CMakeLists.txt

1 line

uvedit/

CMakeLists.txt

3 lines

uvedit_clipboard.cc

376 lines

uvedit_clipboard_graph_iso.hh

40 lines

uvedit_clipboard_graph_iso.cc

427 lines

uvedit_intern.h

12 lines

uvedit_ops.c

2 lines

functions/

CMakeLists.txt

3 lines

FN_field_cpp_type.hh

114 lines

FN_field_cpp_type_make.hh

51 lines

FN_init.h

13 lines

intern/

cpp_types.cc

42 lines

field_cpp_type.cc

39 lines

geometry/

intern/

trim_curves.cc

101 lines

gpencil_modifiers/

CMakeLists.txt

2 lines

MOD_gpencil_lineart.h

8 lines

intern/

lineart/

MOD_lineart.h

9 lines

lineart_cpu.c

	lineart_cpu.cc
	lineart_cpu.c

598 lines

lineart_intern.h

10 lines

gpu/

GPU_state.h

3 lines

GPU_uniform_buffer.h

1 line

intern/

gpu_codegen.cc

24 lines

gpu_node_graph.h

1 line

gpu_node_graph.c

2 lines

gpu_shader_interface.hh

4 lines

gpu_uniform_buffer.cc

5 lines

gpu_uniform_buffer_private.hh

1 line

metal/

mtl_command_buffer.mm

2 lines

mtl_uniform_buffer.hh

1 line

mtl_uniform_buffer.mm

10 lines

opengl/

4 lines

3 lines

1 line

13 lines

shaders/

common/

gpu_shader_common_math_utils.glsl

9 lines

tests/

gpu_testing.hh

29 lines

gpu_testing.cc

2 lines

vulkan/

vk_uniform_buffer.hh

1 line

vk_uniform_buffer.cc

4 lines

io/

collada/

MeshImporter.cpp

6 lines

makesdna/

DNA_object_types.h

3 lines

DNA_space_types.h

10 lines

DNA_texture_types.h

1 line

makesrna/

intern/

1 line

5 lines

1 line

54 lines

2 lines

18 lines

1 line

modifiers/

intern/

MOD_nodes.cc

15 lines

MOD_normal_edit.cc

4 lines

MOD_weighted_normal.cc

35 lines

nodes/

NOD_geometry.h

1 line

NOD_static_types.h

1 line

geometry/

CMakeLists.txt

2 lines

node_geometry_exec.cc

nodes/

node_geo_curve_to_mesh.cc

2 lines

node_geo_image_info.cc

95 lines

node_geo_input_mesh_island.cc

8 lines

node_geo_interpolate_domain.cc

2 lines

node_geo_raycast.cc

20 lines

node_geo_scale_elements.cc

4 lines

intern/

geometry_nodes_lazy_function.cc

61 lines

geometry_nodes_log.cc

5 lines

node_socket.cc

7 lines

windowmanager/

CMakeLists.txt

1 line

intern/

wm_event_system.cc

3 lines

wm_files.c

13 lines

wm_init_exit.c

3 lines

creator/

creator.c

2 lines

Commit	Tree	Parents	Author	Summary	Date
88f2350c343f	7caa7367c8ff	33a1472d4e81	Joseph Eagar	temp-sculpt-roll-mapping: Update comment	Nov 17 2022, 9:43 AM
33a1472d4e81	a31076903966	7a6e2d1e3947	Joseph Eagar	temp-sculpt-roll-mapping: New strategy for spline tex mapping (Show More…)	Nov 17 2022, 9:06 AM
7a6e2d1e3947	ee633295c04e	f8afdc971f47	Joseph Eagar	temp-sculpt-roll-mapping: remove debug draw points	Nov 16 2022, 9:45 AM
f8afdc971f47	1ae65275bc57	9a8c4aefb3b1	Joseph Eagar	temp-sculpt-roll-mappings: Experimental quadratic spline code (Show More…)	Nov 16 2022, 9:40 AM
9a8c4aefb3b1	bb96e4cf59ec	af4048f2b8f3	Joseph Eagar	temp-sculpt-roll-mapping: mirror symmetry fixes	Nov 15 2022, 7:40 PM
af4048f2b8f3	1aaf5bf8d874	eecd4b69f24b	Joseph Eagar	temp-sculpt-roll-mapping: Fix stroke points projection outside of the mesh	Nov 15 2022, 6:13 PM
eecd4b69f24b	92221fff64fe	12c5ae7e06cf	Joseph Eagar	Sculpt: Fix mask from cavity settings issues (Show More…)	Nov 15 2022, 5:39 PM
12c5ae7e06cf	f9c04815fbf5	852a9ffa3df7	Jeroen Bakker	GPU: Update Vulkan backend with latest API changes. (Show More…)	Nov 15 2022, 4:23 PM
852a9ffa3df7	f65c9e22ccc7	893565268dce	Julian Eisel	Fix T102482: Crash loading geometry nodes assets after file load (Show More…)	Nov 15 2022, 4:15 PM
893565268dce	beef8e75bc42	00113d68882a	Germano Cavalcante	Fix T102512: Snapping Option Face Nearest is not working (Show More…)	Nov 15 2022, 4:07 PM
00113d68882a	ae989dd67663	982620415746	Philipp Oeser	Report messages from override ID template to the UI. (Show More…)	Nov 15 2022, 3:53 PM
982620415746	12a33d3f6c75	295dc6133443	Bastien Montagne	Fix `WM_report` not printing into console. (Show More…)	Nov 15 2022, 3:50 PM
295dc6133443	926df9ce4c7c	fc4c8a364720	Bastien Montagne	Fix T102495: Fix UI-invisible warning and failing liboverride creation in… (Show More…)	Nov 15 2022, 3:48 PM
fc4c8a364720	6e182b5a247f	2e4ed11dd3dd	Patrick Mours	Cleanup: Move OptiX denoiser code from device into denoiser class (Show More…)	Nov 15 2022, 1:05 PM
2e4ed11dd3dd	1c3f78fccd7d	f46b932c5901	Bastien Montagne	Fix (unreported) broken args handling in install_deps. (Show More…)	Nov 15 2022, 2:52 PM
f46b932c5901	5a8be7d52816	d67cf5d2888e	Clément Foucault	GPU: UniformBuffer: Add possibility to bind as SSBO (Show More…)	Nov 15 2022, 2:41 PM
d67cf5d2888e	f3ae9a39c08f	0a16677741bf	Clément Foucault	GPU: State: Add GPU_BARRIER_UNIFORM (Show More…)	Nov 15 2022, 2:25 PM
0a16677741bf	9027e5b353ea	f37cbba8f1c5	Jeroen Bakker	GPU: Enabled Metal test cases. (Show More…)	Nov 15 2022, 1:12 PM
f37cbba8f1c5	67e655958626	e2449adfcd1e	Miguel Pozo	GPU: Improve Codegen variable names (Show More…)	Nov 15 2022, 1:06 PM
e2449adfcd1e	a45eef4f18b4	63e630b70334	Miguel Pozo	Fix T101562: GPU: Update fmod to match Cycles/OSL behavior (Show More…)	Nov 15 2022, 1:04 PM
63e630b70334	ff7597767973	c2499366f298	Bastien Montagne	install_deps: Update openpgl to 0.4.1. (Show More…)	Nov 15 2022, 12:43 PM
c2499366f298	98f30de14f62	b30e20d0d978	Jacques Lucke	Cleanup: fix compile error in leak detection utility	Nov 15 2022, 12:41 PM
b30e20d0d978	29323c2422a9	51976a9e4ca2	Jacques Lucke	Fix T101536: missing node tree updates after remapping id (Show More…)	Nov 15 2022, 12:07 PM
51976a9e4ca2	027b98cd19be	6749cec22f2c	Damien Picard	I18n: fix UI layout operator context extraction (Show More…)	Nov 15 2022, 12:03 PM
6749cec22f2c	cb646fd586fe	f5877da993d2	Damien Picard	I18n: fix description_from_data_path() for property assignment (Show More…)	Nov 15 2022, 11:28 AM
f5877da993d2	e53d5bd87ca1	42dd5cc4305e	Damien Picard	I18n: improve keymap translations (Show More…)	Nov 15 2022, 11:02 AM
42dd5cc4305e	6f181935e444	e16f473523c5	Amelie Fondevilla	Fix T101775: grease pencil keyframe not filtered in dopesheet summary (Show More…)	Nov 15 2022, 9:23 AM
e16f473523c5	cf0eefde19f6	a97e2fd4e6e7	Amelie Fondevilla	Animation: rearrange grease pencil channels in the main dopesheet (Show More…)	Nov 14 2022, 5:50 PM
a97e2fd4e6e7	58664ed72452	b0e48cb9364e	Jeroen Bakker	Fix hair/curve drawing artifacts when workarounds are enabled. (Show More…)	Nov 15 2022, 8:07 AM
b0e48cb9364e	dbfa8c9594a9	dc14353791b0	Campbell Barton	Cleanup: format	Nov 15 2022, 6:43 AM
dc14353791b0	e6e062164544	03218f7b4532	Campbell Barton	Cleanup: quiet unused variable warning	Nov 15 2022, 6:41 AM
03218f7b4532	a3503b49ae1f	472762f0dc83	Campbell Barton	GHOST/Wayland: limit the size of the events_pending vector (Show More…)	Nov 15 2022, 6:33 AM
472762f0dc83	6480e1b91f00	6868d7b74a6f	Campbell Barton	Fix T100855: Input while Blender is unresponsive exits under Wayland (Show More…)	Nov 11 2022, 12:57 AM
6868d7b74a6f	36c7710a636b	a3c4e28df9fb	Campbell Barton	GHOST/Wayland: share logic for xdg/libdecor window configuration (Show More…)	Nov 15 2022, 4:49 AM
a3c4e28df9fb	324d16fcc08c	444ce7c3b76d	Campbell Barton	GHOST/Wayland: only use a single swapBuffers for libdecor redrawing (Show More…)	Nov 15 2022, 2:28 AM
444ce7c3b76d	acaabbfccd7e	24044c64bae4	Iliya Katueshenock	Geometry Nodes: Image Info Node (Show More…)	Nov 15 2022, 1:55 AM
24044c64bae4	9c2bd008eb0a	9dd0899298f7	Mattias Fredriksson	Partial Fix T102428: Invertible Bezier curve trim within one segment (Show More…)	Nov 15 2022, 1:20 AM
9dd0899298f7	38db880c9d74	0783789a9567	Laurynas Duburas	Fix: Versioning problem with cyclic bezier NURBS (Show More…)	Nov 15 2022, 1:04 AM
0783789a9567	88a0ed8fb693	7e1898cfa77d	Hans Goudey	Fix T102502: Collada import sets incorrect material indices (Show More…)	Nov 15 2022, 12:52 AM
7e1898cfa77d	90489f78e2eb	a67f703ff301	Hans Goudey	Cleanup: Resolve unused variable warning in draw module	Nov 14 2022, 9:49 PM
a67f703ff301	7b9141adced3	a504c9a69e12	Richard Antalik	Fix T100491: Mouse selection is inaccurate in NLA Editor (Show More…)	Nov 14 2022, 7:57 PM
a504c9a69e12	b2557c9b93ee	e86612d4427d	Brecht Van Lommel	Python API: add Image.save() optional parameters quality and filepath (Show More…)	Nov 14 2022, 4:15 PM
e86612d4427d	09cc95e03f66	63d4f862ce8a	Brecht Van Lommel	Fix T102421: Image.save() not respecting set image.file_format (Show More…)	Nov 14 2022, 5:09 PM
63d4f862ce8a	202afa8d4f21	8a19fcc50086	Hans Goudey	Cleanup: BVH utils: Remove print, use spans instead of pointers	Nov 14 2022, 6:59 PM
8a19fcc50086	718b490af749	ed4e04a1f6d4	Michael Jones	Cycles: Enable MetalRT pointclouds & other fixes (Show More…)	Nov 14 2022, 4:35 PM
ed4e04a1f6d4	c06880dcbd61	96e93cc70cd0	Bastien Montagne	Usual minor fixes to UI messages & i18m utils module.	Nov 14 2022, 4:44 PM
96e93cc70cd0	06cc35dfbe81	85dc681fc351	Hans Goudey	Mesh: Avoid calculating normals when building BVH tree (Show More…)	Nov 14 2022, 6:54 AM
85dc681fc351	567701baf8a3	e442a17587d7	Hans Goudey	Cleanup: Reduce indentation and variable scope in BVH utils	Nov 14 2022, 6:32 AM
e442a17587d7	bc3bc8f01187	f4e4a0b5b3e6	Hans Goudey	Cleanup: Use C++ BitVector instead of BLI_bitmap for BVH utils (Show More…)	Nov 14 2022, 6:23 AM
f4e4a0b5b3e6	4a51c47de3cf	dd669dd70378	Hans Goudey	Cleanup: Allow using C++ features in BMesh header functions (Show More…)	Nov 14 2022, 6:08 AM
dd669dd70378	44b4d93dcbcc	adf4dd835515	Hans Goudey	Cleanup: Move bmesh_iterators.c to C++	Nov 14 2022, 5:43 AM
adf4dd835515	a62a7bfccf51	9b36b846f0f0	Sergey Sharybin	Cleanup: Braces around initialization warning (Show More…)	Nov 14 2022, 2:43 PM
9b36b846f0f0	f570efd069e5	9d74da335233	Ejner Fergo	Gizmo toggle for Movie Clip Editor (Show More…)	Nov 14 2022, 2:27 PM
9d74da335233	9842c32ff73f	a72f590d5165	Mikhail Matrosov	Cycles: improve adaptive sampling for overexposed scenes (Show More…)	Nov 14 2022, 2:13 PM
a72f590d5165	894bda778598	6b590a86a607	Brecht Van Lommel	Fix image datablock losing movie metadata on undo (Show More…)	Nov 14 2022, 1:14 PM
6b590a86a607	c328a4398c9e	48527a5c2db8	Colin Basnett	UI: disable curve map & profile zoom buttons at max/min zoom level (Show More…)	Nov 14 2022, 1:11 PM
48527a5c2db8	309e252d6831	94e761e26389	Clément Foucault	DRW: Fix compilation issues in inline functions	Nov 14 2022, 2:01 PM
94e761e26389	a61f2d382f7f	85cec1deffaf	Iliya Katueshenock	Fix: incorrect field dependencies in the raycast node (Show More…)	Nov 14 2022, 1:18 PM
85cec1deffaf	c9b55446edb5	165daf0bc6d6	Julian Eisel	Asset system: New asset system code module (with files from BKE) (Show More…)	Nov 14 2022, 12:41 PM
165daf0bc6d6	bd7daa52851f	aed5a62db4f2	Miguel Pozo	Fix T98989: Performance regression when using multiple bump nodes (Show More…)	Nov 14 2022, 12:21 PM
aed5a62db4f2	e0d4cad18ebb	0c1b536c574f	Campbell Barton	GHOST/Wayland: fix building when GHOST_OPENGL_ALPHA is defined	Nov 14 2022, 2:01 AM
0c1b536c574f	892e21ffffa1	903c25f09716	Clément Foucault	DRW: View: Add base for multi-view support (Show More…)	Nov 14 2022, 12:42 AM
903c25f09716	96e156632d5a	6e2fc39eb740	Clément Foucault	Cleanup: DRW: Remove two clang-tidy warnings	Nov 13 2022, 9:33 PM
6e2fc39eb740	8f9e7634d832	f2f1bbdea3af	Hans Goudey	Cleanup: Move mesh_remap.c to C++ (Show More…)	Nov 14 2022, 3:26 AM
f2f1bbdea3af	584f60018ddd	96dfc8be8ed7	Chris Blackbourn	UV: fix crash with uv copy on empty selection (Show More…)	Nov 14 2022, 1:35 AM
96dfc8be8ed7	71d5bf228708	4d57da0dd0be	Campbell Barton	GHOST/Wayland: call exit() when Wayland has a fatal error (Show More…)	Nov 14 2022, 12:28 AM
4d57da0dd0be	afe1ce498e5b	9eb885d029c8	Campbell Barton	GHOST/Wayland: remove display listener (was warning on startup) (Show More…)	Nov 14 2022, 12:12 AM
9eb885d029c8	f59bebd9142a	e2376eceb537	Hans Goudey	Cleanup: Disable mesh normal debug time printing (Show More…)	Nov 13 2022, 9:19 PM
e2376eceb537	8a03f95083cb	f9947b50c6f2	Hans Goudey	Cleanup: Move lineart_cpu.c to C++ (Show More…)	Nov 13 2022, 9:16 PM
f9947b50c6f2	2a656b390dd7	812de962a360	Chris Blackbourn	UV: fix compile on windows (Show More…)	Nov 13 2022, 8:20 PM
812de962a360	4399196a604d	8bea9693df91	Howard Trickey	Fix T95335 Bevel operator Loop Slide overshoot. (Show More…)	Nov 13 2022, 8:09 PM
8bea9693df91	f53da84308d2	035e040ee2de	Pratik Borhade	Fix T102187: Add knife tool in mesh panel (Show More…)	Nov 13 2022, 6:18 PM
035e040ee2de	fe1d37012d6a	da33e57e3918	Clément Foucault	DRW: Manager: Fix `ClearMulti` breaking compilation on Mac (Show More…)	Nov 13 2022, 6:02 PM
da33e57e3918	33327e6fd471	6ee2f9dc155f	Clément Foucault	BLI: Fix `ListBaseWrapper::get` wrong return type	Nov 13 2022, 4:48 PM
6ee2f9dc155f	3f6f11fa6ae5	453a0c430b22	Clément Foucault	DRW: Manager: Add `bind_texture` command for vertex buffer (Show More…)	Nov 13 2022, 4:47 PM
453a0c430b22	b379e79dcf3e	94a35be532ea	Clément Foucault	DRW: Manager: Add `ClearMulti` command (Show More…)	Nov 13 2022, 4:23 PM
94a35be532ea	f01473ce910f	4efef2fccd40	Clément Foucault	DRW: Manager: Finish / change implementation of `framebuffer_set` command (Show More…)	Nov 13 2022, 4:08 PM
4efef2fccd40	c14beba2d083	a80e4f4bc956	Clément Foucault	DRW: Wrappers: Allow taking reference of the framebuffer object (Show More…)	Nov 13 2022, 4:02 PM
a80e4f4bc956	3db755ff12d7	8e40e6400a99	Clément Foucault	DRW: Wrappers: Allow trivial types inside `draw::SwapChain` (Show More…)	Nov 13 2022, 4:00 PM
8e40e6400a99	3bb38bb5edef	9f1560a9a4a7	Clément Foucault	DRW: Wrappers: Avoid default vector length of 0 if sizeof(T) is large (Show More…)	Nov 13 2022, 3:59 PM
9f1560a9a4a7	d6c8ceaed1aa	dce36e3e802e	Jacques Lucke	Cleanup: fix compiler error/warnings	Nov 13 2022, 11:29 AM
dce36e3e802e	3b286dac29d8	be9bac1f0d2f	Chris Blackbourn	UV: implement copy and paste for uv (Show More…)	Nov 13 2022, 12:27 AM
be9bac1f0d2f	ddd710ec31fd	0f06080bc3ed	Ray Molenkamp	Fix: OpenSubdiv reporting version 0.0.0 in system_info.txt (Show More…)	Nov 12 2022, 9:31 PM
0f06080bc3ed	58447435d51a	b5d4fbb9cc56	Hans Goudey	Cleanup: Move cloth.c to C++ (Show More…)	Nov 12 2022, 6:48 PM
b5d4fbb9cc56	dba5fae51330	431d52767934	Jacques Lucke	BLI: improve CPPType system (Show More…)	Nov 12 2022, 6:33 PM
431d52767934	21dec5288c69	d5dff81cf669	Philipp Oeser	Fix: Curves sculptmode: deduplicate checks for being in mode (Show More…)	Nov 11 2022, 3:07 PM
d5dff81cf669	9ff3d92c2436	c619c866621c	Iliya Katueshenock	BLI: use templates for disjoint set data structure (Show More…)	Nov 12 2022, 2:26 PM
c619c866621c	ed974652e240	dba0a2ad9a96	Iliya Katueshenock	Fix: missing tooltip for color sockets (Show More…)	Nov 12 2022, 2:22 PM
dba0a2ad9a96	be2ca39b4964	2a90fc497b6f	Iliya Katueshenock	Cleanup: remove unused variable (Show More…)	Nov 12 2022, 2:20 PM
2a90fc497b6f	6fcef86d149e	36673016e96d	Iliya Katueshenock	Fix: geometry nodes viewer shows black with dangling reroute input (Show More…)	Nov 12 2022, 2:18 PM
36673016e96d	2e1972da7fa5	30e9c5b7f535	Iliya Katueshenock	Cleanup: make GArray declarations more explicit (Show More…)	Nov 12 2022, 2:14 PM
30e9c5b7f535	6e1a9c3bc65f	6e82f6bf2fe0	Campbell Barton	Cleanup: add a system reference to the wayland window (Show More…)	Nov 12 2022, 7:35 AM
6e82f6bf2fe0	64690b14c277	f6f05740bec0	Campbell Barton	Fix window title not redrawing with Wayland/libdecor	Nov 12 2022, 7:06 AM
f6f05740bec0	2a45456b8be9	a873f7299a38	Campbell Barton	GHOST/Wayland: skip resizing the EGL surface unnecessarily (Show More…)	Nov 12 2022, 6:38 AM
a873f7299a38	f2c6c0c95afe	9f03d4bc2cef	Campbell Barton	Cleanup: move title into GWL_Window (Show More…)	Nov 12 2022, 6:26 AM
9f03d4bc2cef	fbaf48f11c53	dc2ac546cdd9	Campbell Barton	Cleanup: move Wayland window state utilities into lower level functions (Show More…)	Nov 12 2022, 6:26 AM
dc2ac546cdd9	cea128856970	a3f23a321ea0	Campbell Barton	Fix non-interactive window borders after changes to event handling (Show More…)	Nov 12 2022, 6:26 AM
a3f23a321ea0	50ea2d676858	ddecc6166bc1	Campbell Barton	Cleanup: use snake-case for WAYLAND utility functions (Show More…)	Nov 12 2022, 5:23 AM
ddecc6166bc1	33b00fb6e3a0	91556088752c	Campbell Barton	GHOST/Wayland: replace roundtrip with dispatch_pending (Show More…)	Nov 10 2022, 8:03 AM
91556088752c	69855e9908cb	415ed999abb6	Hans Goudey	Cleanup: Simplify handling of loop to poly map in normal calculation (Show More…)	Nov 12 2022, 5:56 AM
415ed999abb6	cc7881f8459f	cfab4f432c1f	Hans Goudey	Cleanup: Use simpler timers for mesh normals debug timing	Nov 12 2022, 5:11 AM
cfab4f432c1f	7fe474c49095	4ac1f59a81f8	Hans Goudey	Cleanup: Make loop normal calculation function static	Nov 12 2022, 4:58 AM
4ac1f59a81f8	5ef44f20e086	1ed9df3763d1	Hans Goudey	Cleanup: Decrease variable scope in mesh loop normal calculation	Nov 12 2022, 4:56 AM
1ed9df3763d1	b7fca9f59854	61e591b2a5a0	Hans Goudey	Cleanup: Use spans for loop normal calculation input data	Nov 12 2022, 4:49 AM
61e591b2a5a0	3df9295a0e4e	c29795452cc7	Hans Goudey	Cleanup: Remove unnecessary struct keywords	Nov 12 2022, 2:05 AM
c29795452cc7	53a46bb77f31	9980fd0b8e1f 03ccf37162d3	Joseph Eagar	Merge branch 'master' into temp-sculpt-roll-mapping	Nov 11 2022, 11:18 PM
9980fd0b8e1f	2fd373a0ef98	db3bf3677085	Joseph Eagar	temp-sculpt-roll-mapping: Port roll tex mapping code from sculpt-dev	Nov 5 2022, 10:47 PM

Sculpt: Stroke Texture MappingNeeds ReviewPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 57723

build_files/build_environment/install_deps.sh

intern/cycles/CMakeLists.txt

intern/cycles/device/CMakeLists.txt

intern/cycles/device/denoise.h

intern/cycles/device/device.h

intern/cycles/device/metal/bvh.mm

intern/cycles/device/metal/device_impl.mm

intern/cycles/device/metal/kernel.h

intern/cycles/device/metal/kernel.mm

intern/cycles/device/optix/device_impl.h

intern/cycles/device/optix/device_impl.cpp

intern/cycles/integrator/CMakeLists.txt

intern/cycles/integrator/denoiser.cpp

intern/cycles/integrator/denoiser_device.h

intern/cycles/integrator/denoiser_device.cpp

intern/cycles/integrator/denoiser_gpu.h

intern/cycles/integrator/denoiser_gpu.cpp

intern/cycles/integrator/denoiser_optix.h

intern/cycles/integrator/denoiser_optix.cpp

intern/cycles/kernel/data_template.h

intern/cycles/kernel/device/metal/bvh.h

intern/cycles/kernel/device/metal/kernel.metal

intern/cycles/kernel/film/adaptive_sampling.h

intern/cycles/scene/object.cpp

intern/ghost/CMakeLists.txt

intern/ghost/intern/GHOST_SystemWayland.h

intern/ghost/intern/GHOST_SystemWayland.cpp

intern/ghost/intern/GHOST_WindowWayland.h

intern/ghost/intern/GHOST_WindowWayland.cpp

intern/opensubdiv/internal/base/opensubdiv_capi.cc

intern/wayland_dynload/extern/wayland_dynload_client.h

release/scripts/modules/bl_i18n_utils/bl_extract_messages.py

release/scripts/modules/bl_i18n_utils/settings.py

release/scripts/modules/bl_i18n_utils/utils_spell_check.py

release/scripts/modules/rna_keymap_ui.py

release/scripts/startup/bl_operators/wm.py

release/scripts/startup/bl_ui/node_add_menu_geometry.py

release/scripts/startup/bl_ui/properties_paint_common.py

release/scripts/startup/bl_ui/space_clip.py

release/scripts/startup/bl_ui/space_image.py

release/scripts/startup/bl_ui/space_view3d.py

source/blender/CMakeLists.txt

source/blender/asset_system/AS_asset_catalog.hh

source/blender/asset_system/AS_asset_catalog_path.hh

source/blender/asset_system/AS_asset_library.h

source/blender/asset_system/AS_asset_library.hh

source/blender/asset_system/AS_asset_representation.h

source/blender/asset_system/AS_asset_representation.hh

source/blender/asset_system/CMakeLists.txt

source/blender/asset_system/intern/asset_catalog.cc

source/blender/asset_system/intern/asset_catalog_path.cc

source/blender/asset_system/intern/asset_library.cc

source/blender/asset_system/intern/asset_library_service.hh

source/blender/asset_system/intern/asset_library_service.cc

source/blender/asset_system/intern/asset_representation.cc

source/blender/asset_system/tests/asset_catalog_path_test.cc

source/blender/asset_system/tests/asset_catalog_test.cc

source/blender/asset_system/tests/asset_library_service_test.cc

source/blender/asset_system/tests/asset_library_test.cc

source/blender/blenkernel/BKE_asset.h

source/blender/blenkernel/BKE_asset_catalog.hh

source/blender/blenkernel/BKE_asset_catalog_path.hh

source/blender/blenkernel/BKE_asset_library.h

source/blender/blenkernel/BKE_asset_library.hh

source/blender/blenkernel/BKE_asset_representation.hh

source/blender/blenkernel/BKE_bvhutils.h

source/blender/blenkernel/BKE_cloth.h

source/blender/blenkernel/BKE_cpp_types.h

source/blender/blenkernel/BKE_mesh.h

source/blender/blenkernel/BKE_mesh_mapping.h

source/blender/blenkernel/BKE_nla.h

source/blender/blenkernel/BKE_node.h

source/blender/blenkernel/BKE_shrinkwrap.h

source/blender/blenkernel/CMakeLists.txt

Sculpt: Stroke Texture Mapping
Needs ReviewPublic
Actions

Revision Contents
Changeset List