Page MenuHome
Differential D16422

Add volume support
ClosedPublic
Actions

Authored by Weizhen Huang (weizhen) on Nov 8 2022, 5:09 PM.

Details

Reviewers
Brecht Van Lommel (brecht)
Commits
rB673ec13ffc56: Add volume support

Diff Detail

Repository
rB Blender
Branch
soc-2022-many-lights-sampling
Build Status
Buildable 24563
Build 24563: arc lint + arc unit

Event Timeline

Weizhen Huang (weizhen) requested review of this revision.Nov 8 2022, 5:09 PM
Weizhen Huang (weizhen) created this revision.
Harbormaster completed remote builds in B24543: Diff 57360.Nov 8 2022, 5:09 PM
Weizhen Huang (weizhen) added a reviewer: Brecht Van Lommel (brecht).Nov 8 2022, 5:14 PM
Weizhen Huang (weizhen) updated this revision to Diff 57369.Nov 8 2022, 7:39 PM

clamp tmax for world volume

Harbormaster completed remote builds in B24548: Diff 57369.Nov 8 2022, 7:39 PM
Alaska (Alaska) added a subscriber: Alaska (Alaska).Nov 8 2022, 11:24 PM
Xianyao Zhang (mkimish) added a subscriber: Xianyao Zhang (mkimish).Nov 8 2022, 11:29 PM
Weizhen Huang (weizhen) updated this revision to Diff 57396.Nov 9 2022, 12:03 PM

Bug fix, cos(theta') was not used for volume

Harbormaster completed remote builds in B24558: Diff 57396.Nov 9 2022, 12:03 PM
Brecht Van Lommel (brecht) accepted this revision.Nov 9 2022, 1:08 PM
This revision is now accepted and ready to land.Nov 9 2022, 1:08 PM
Weizhen Huang (weizhen) updated this revision to Diff 57401.Nov 9 2022, 1:16 PM

maybe also consider phase function in volume in the future

Harbormaster completed remote builds in B24563: Diff 57401.Nov 9 2022, 1:16 PM
Weizhen Huang (weizhen) added a commit: rB673ec13ffc56: Add volume support.Nov 9 2022, 1:19 PM
Weizhen Huang (weizhen) closed this revision.Nov 9 2022, 2:00 PM

committed

Revision Contents
Changeset List

PathSize
intern/
cycles/
kernel/
integrator/
4 lines
light/
36 lines
304 lines

Diff 57401

View Options

intern/cycles/kernel/integrator/shade_volume.h

Loading...
View Options

intern/cycles/kernel/light/sample.h

Loading...
View Options

intern/cycles/kernel/light/tree.h

Loading...