Differential D16423
Depsgraph: Simplify scheduling in depsgraph evaluator. Authored by Jacques Lucke (JacquesLucke) on Nov 8 2022, 5:16 PM.
Details The code used a weird combination of c-style function points with c++ templates. Using FunctionRef allows writing the same code much simpler. I also removed the thread_id argument because it was never used. No functional or performance changes are expected.
Diff Detail
Event TimelineComment Actions Is it a simple cleanup? Are there any functional changes expected? Is there any performance penalty of using FunctionRef over function pointer? Comment Actions
Yes.
No.
The generated assembly will likely be a little bit different, could be slightly better or worse depending on the number of captured args. Either way, this is completely negligible here. Comment Actions Thanks for clarification! I kinda like that we go away from those variadic templates :) |