Page MenuHome
Differential D16425

Fix T98989: Performance regression when using multiple bump nodes
ClosedPublic
Actions

Authored by Miguel Pozo (pragma37) on Nov 8 2022, 9:12 PM.

Details

Reviewers
Clément Foucault (fclem)
Maniphest Tasks
T98989: Regression: Eevee bad performance when using procedural bump map.
Commits
rBa84c92fc73d3: Fix T98989: Performance regression when using multiple bump nodes
Summary

Ensure each graph material_function only evaluates the input links that are connected to it.

This requires more testing and the foreach_linked_input_recursive function might be better placed somewhere else.

GPU_NODE_TAG_FUNCTION is no longer needed, so it could probably be removed too.

Diff Detail

Repository
rB Blender
Branch
blender-v3.4-release
Build Status
Buildable 24618
Build 24618: arc lint + arc unit

Event Timeline

Miguel Pozo (pragma37) requested review of this revision.Nov 8 2022, 9:12 PM
Miguel Pozo (pragma37) created this revision.
Harbormaster completed remote builds in B24551: Diff 57377.Nov 8 2022, 9:12 PM
Miguel Pozo (pragma37) edited the summary of this revision. (Show Details)Nov 8 2022, 9:13 PM
Sun Kim (persun) added a subscriber: Sun Kim (persun).Nov 8 2022, 10:47 PM
Evan Wilson (EAW) added a subscriber: Evan Wilson (EAW).Nov 8 2022, 10:52 PM
Miguel Pozo (pragma37) added a comment.Nov 10 2022, 3:37 PM

I've looked a bit more into it and I don't think it has any major issues.

GPU_NODE_TAG_FUNCTION can't be removed since untagged nodes get removed.

Jeroen Bakker (jbakker) added a task: T98989: Regression: Eevee bad performance when using procedural bump map..Nov 11 2022, 12:22 PM
Jeroen Bakker (jbakker) awarded a token.
Miguel Pozo (pragma37) updated this revision to Diff 57511.Nov 11 2022, 5:24 PM

Updated to fix an issue where the same node was serialized more than once inside the same function when connected to more than one input socket.

Harbormaster completed remote builds in B24617: Diff 57511.Nov 11 2022, 5:24 PM
Miguel Pozo (pragma37) updated this revision to Diff 57512.Nov 11 2022, 5:56 PM

Leave the tags as they were, just in case

Harbormaster completed remote builds in B24618: Diff 57512.Nov 11 2022, 5:56 PM
Clément Foucault (fclem) accepted this revision.Nov 12 2022, 8:21 PM
This revision is now accepted and ready to land.Nov 12 2022, 8:21 PM
Closed by commit rBa84c92fc73d3: Fix T98989: Performance regression when using multiple bump nodes (authored by Miguel Pozo (pragma37)). · Explain WhyNov 14 2022, 12:24 PM
This revision was automatically updated to reflect the committed changes.
Miguel Pozo (pragma37) added a commit: rBa84c92fc73d3: Fix T98989: Performance regression when using multiple bump nodes.

Revision Contents
Changeset List

PathSize
source/
blender/
gpu/
intern/
10 lines
3 lines
2 lines

Diff 57512

View Options

source/blender/gpu/intern/gpu_codegen.cc

Loading...
View Options

source/blender/gpu/intern/gpu_node_graph.h

Loading...
View Options

source/blender/gpu/intern/gpu_node_graph.c

Loading...