Page MenuHome

Cleanup: Fixing anti-patterns in fcurve.c
ClosedPublic

Authored by Colin Basnett (cmbasnett) on Nov 11 2022, 1:26 AM.

Details

Summary

This is a clean-up pass that eliminates a few problematic patterns:

  • Eliminating redundant parentheses around simple expressions.
  • Combing declaration and assignment of variables where appropriate.
  • Moving variable declarations closer to their first use.
  • Many variables and arguments have been marked as const.
  • Using LISTBASE_FOREACH_* variants where applicable instead of manually managing loop control flow.

There are no functional changes.

Diff Detail

Repository
rB Blender

Event Timeline

Colin Basnett (cmbasnett) requested review of this revision.Nov 11 2022, 1:26 AM
Colin Basnett (cmbasnett) created this revision.
Colin Basnett (cmbasnett) retitled this revision from Code clean-up in fcurve.c to Cleanup: Fixing anti-patterns in fcurve.c.Nov 11 2022, 1:38 AM

Much improvements, thanks!

This revision is now accepted and ready to land.Nov 11 2022, 12:48 PM