Page MenuHome

Fix: Curves sculptmode: paintcurve stroke points cannot be transformed
ClosedPublic

Authored by Philipp Oeser (lichtwerk) on Nov 11 2022, 1:06 PM.

Details

Summary

As part of rB3f91540cef7e, we already made OB_MODE_SCULPT_CURVES to be
allowed in paint_curve_poll (alongside OB_MODE_ALL_PAINT).
Now, to get the paintcurves transform systems to work with curves
sculptmode as well, we introduce this "additional case" in the
appropriate place in the transform system as well.

NOTE: as a next step, considering OB_MODE_SCULPT_CURVES to be generally part of OB_MODE_ALL_PAINT is to be done (this might fix another couple of bugs, but also has to be carefully checked in many places, so this patch is just fixing this very specific case)

Fixes T102204.

Diff Detail

Repository
rB Blender
Branch
T102204 (branched from master)
Build Status
Buildable 24607
Build 24607: arc lint + arc unit

Event Timeline

Philipp Oeser (lichtwerk) requested review of this revision.Nov 11 2022, 1:06 PM
Philipp Oeser (lichtwerk) created this revision.
This revision is now accepted and ready to land.Nov 11 2022, 1:12 PM
Germano Cavalcante (mano-wii) added inline comments.
source/blender/editors/transform/transform_convert.c
1112

I considered merging the flags:

if (ob && (ob->mode & (OB_MODE_ALL_PAINT | OB_MODE_SCULPT_CURVES))) {

No strong opinion about it.

source/blender/editors/transform/transform_convert.c
1112

Oops, saw this a bit late, but since this is very likely to end up in OB_MODE_ALL_PAINT anyways in a following commit, will leave for now