Differential D16497

Fix T101562: GPU: Update fmod to match Cycles/OSL behavior
ClosedPublic
Actions

Authored by Miguel Pozo (pragma37) on Nov 14 2022, 4:14 PM.

Tags

None

Subscribers

None

Details

Reviewers

Clément Foucault (fclem)

Maniphest Tasks

T101562: 7 mod 7 in Eevee Math Node return an incorrect value

Commits

rB21eeedfc60b5: Fix T101562: GPU: Update fmod to match Cycles/OSL behavior

Summary

Implementation from:
https://github.com/AcademySoftwareFoundation/OpenShadingLanguage/blob/main/src/include/OSL/dual.h#L1283
https://github.com/OpenImageIO/oiio/blob/master/src/include/OpenImageIO/fmath.h#L1605

Diff Detail

Repository: rB Blender

Event Timeline

Miguel Pozo (pragma37) requested review of this revision.Nov 14 2022, 4:14 PM

Miguel Pozo (pragma37) created this revision.

Harbormaster completed remote builds in B24634: Diff 57605.Nov 14 2022, 4:14 PM

Miguel Pozo (pragma37) added a task: T101562: 7 mod 7 in Eevee Math Node return an incorrect value.Nov 14 2022, 4:15 PM

Clément Foucault (fclem) accepted this revision.Nov 15 2022, 8:50 AM

This revision is now accepted and ready to land.Nov 15 2022, 8:50 AM

Closed by commit rB21eeedfc60b5: Fix T101562: GPU: Update fmod to match Cycles/OSL behavior (authored by Miguel Pozo (pragma37)). · Explain WhyNov 15 2022, 1:05 PM

This revision was automatically updated to reflect the committed changes.

Miguel Pozo (pragma37) added a commit: rB21eeedfc60b5: Fix T101562: GPU: Update fmod to match Cycles/OSL behavior.

Revision Contents
Changeset List

Path

Size

source/

blender/

gpu/

shaders/

common/

gpu_shader_common_math_utils.glsl

9 lines

Diff 57647

source/blender/gpu/shaders/common/gpu_shader_common_math_utils.glsl

Loading...