Page MenuHome

DRW: Fix pointcloud selection
ClosedPublic

Authored by Jarrett Johnson (jarrett.johnson) on Nov 14 2022, 7:22 PM.

Diff Detail

Repository
rB Blender
Branch
pointcloud_select (branched from master)
Build Status
Buildable 24644
Build 24644: arc lint + arc unit

Event Timeline

Jarrett Johnson (jarrett.johnson) created this revision.
Clément Foucault (fclem) requested changes to this revision.Nov 14 2022, 9:34 PM
Clément Foucault (fclem) added inline comments.
source/blender/draw/engines/basic/basic_engine.c
194–195

This need to be removed. And instead add a return here as the drawcall has already been made by DRW_shgroup_pointcloud_create_sub.

If we return in the added case above, this would bypass the is_flat_object_viewed_from_side check. But I don't know how useful this check is for pointclouds or if it is even desirable.

This revision now requires changes to proceed.Nov 14 2022, 9:34 PM
  • Remove old pc draw and return early
Jarrett Johnson (jarrett.johnson) added inline comments.
source/blender/draw/engines/basic/basic_engine.c
194–195

Lemme know if this new change is fine. Like you mentioned, it's probably not intended for pointclouds. They aren't flat from any angle and in wireframe, they seem to render as billboarded quads which face the camera.

This revision is now accepted and ready to land.Nov 14 2022, 10:59 PM
This revision was automatically updated to reflect the committed changes.