Page MenuHome

Realtime Compositor: Warn about unsupported setups
ClosedPublic

Authored by Omar Emara (OmarSquircleArt) on Nov 15 2022, 9:35 AM.

Details

Summary

This patch warns the user that the compositor setup is not fully
supported when an unsupported node is used. The warning is displayed as
an engine warning overlay.

See T102353.

Diff Detail

Repository
rB Blender

Event Timeline

Omar Emara (OmarSquircleArt) requested review of this revision.Nov 15 2022, 9:35 AM
  • Add warning in node header.
Hans Goudey (HooglyBoogly) added inline comments.
source/blender/blenkernel/BKE_node.h
333–336

It looks like you use the same string for every single node. Does it really need to be stored here? I'd think you could just use the string directly in the the UI code.

The null status of one of these callbacks could check whether the GPU compositor is supported, or this could be replaced with a boolean

source/blender/blenkernel/BKE_node.h
333–336

It looks like you use the same string for every single node. Does it really need to be stored here? I'd think you could just use the string directly in the the UI code.

The null status of one of these callbacks could check whether the GPU compositor is supported, or this could be replaced with a boolean

@Hans Goudey (HooglyBoogly) It is actually not the same for all nodes. Some nodes will have partial support, so the message will reflect that, see the Render Layers message for instance. I know having it here is not great, but it is just temporary solution until we support all nodes.

It should be noted that unspported nodes still define the callbacks, because they implement an identity version of the operation, for instance, an unsupported blur node just doesn't blur the input and pass it through.

For handling translations, I'd suggest using N_ around the string literals and using TIP_ when displaying them in the UI.

source/blender/blenkernel/BKE_node.h
333–336

Ah, sorry, looks like I didn't search the patch correctly. Thanks for clarifying

This revision is now accepted and ready to land.Nov 22 2022, 10:52 AM