Page MenuHome
Differential D16511

Sculpt Mode: Resolve `Shift R` shortcut conflicts
ClosedPublic
Actions

Authored by Julien Kaspar (JulienKaspar) on Nov 15 2022, 10:40 AM.

Details

Reviewers
Joseph Eagar (joeedh)
Hans Goudey (HooglyBoogly)
Aaron Carlisle (Blendify)
Maniphest Tasks
T99607: Resolve "Shift R" shortcut conflict
Commits
rB3e9039091870: Sculpt: Resolve `Shift R` shortcut conflicts
Summary

Based on T99607:

  • Existing Angle Control shortcuts are removed
  • Voxel, Dyntopo and Hair resolution shortcuts are remapped to R

Since voxel remeshing is not compatible with dyntopo, each can use the shortcut R for the remeshing resolution without causing a conflict.
The shortcut R is not currently used for anything important.
The angle control menu is commonly not used.
And sculpt mode is only coincidentally inheriting the rotate operator shortcut on R because nothing else is mapped to the key.

Diff Detail

Repository
rB Blender
Branch
master
Build Status
Buildable 24652
Build 24652: arc lint + arc unit

Event Timeline

Julien Kaspar (JulienKaspar) requested review of this revision.Nov 15 2022, 10:40 AM
Julien Kaspar (JulienKaspar) created this revision.
Harbormaster completed remote builds in B24652: Diff 57639.Nov 15 2022, 10:40 AM
Julien Kaspar (JulienKaspar) added a task: T99607: Resolve "Shift R" shortcut conflict .Nov 15 2022, 10:41 AM
Julien Kaspar (JulienKaspar) edited the summary of this revision. (Show Details)Nov 15 2022, 10:44 AM
Julien Kaspar (JulienKaspar) added reviewers: Joseph Eagar (joeedh), Hans Goudey (HooglyBoogly).
Julien Kaspar (JulienKaspar) added projects: Sculpt, Paint & Texture, Nodes & Physics.
Enrique Barranco (ebarranco) awarded a token.Nov 15 2022, 11:23 PM
Ramil Roosileht (Limarest) awarded a token.Nov 17 2022, 12:24 PM
Hans Goudey (HooglyBoogly) requested changes to this revision.Nov 17 2022, 11:38 PM
Hans Goudey (HooglyBoogly) added inline comments.
release/scripts/presets/keyconfig/keymap_data/blender_default.py
4921–4969

These two changes break the keymap completely. It looks like you forgot to remove the op_menu word too.

This revision now requires changes to proceed.Nov 17 2022, 11:38 PM
Julien Kaspar (JulienKaspar) updated this revision to Diff 57771.Nov 18 2022, 12:06 PM

Removed leftover op_menu from lines.

Harbormaster completed remote builds in B24715: Diff 57771.Nov 18 2022, 12:06 PM
Julien Kaspar (JulienKaspar) marked an inline comment as done.Nov 18 2022, 12:07 PM

Addressed note. This should fix the keymap.

Hans Goudey (HooglyBoogly) accepted this revision.Nov 18 2022, 2:45 PM
This revision is now accepted and ready to land.Nov 18 2022, 2:45 PM
Paul Kotelevets (1D_Inc) awarded a token.Nov 18 2022, 3:53 PM
Aaron Carlisle (Blendify) requested changes to this revision.Dec 8 2022, 5:51 PM
Aaron Carlisle (Blendify) added a subscriber: Aaron Carlisle (Blendify).

Is there a similar conflict in the industry standard key map? if so it should be fixed there also.

I would recommend removing the shortcut from the industry standard keymap anyways and then remove VIEW3D_MT_angle_control

This revision now requires changes to proceed.Dec 8 2022, 5:51 PM
Julien Kaspar (JulienKaspar) updated this revision to Diff 58513.Dec 12 2022, 3:15 PM

Removed angle control shortcuts from industry compatible keymap.

Harbormaster completed remote builds in B25004: Diff 58513.Dec 12 2022, 3:15 PM
Julien Kaspar (JulienKaspar) added a comment.Dec 12 2022, 3:19 PM

@Aaron Carlisle (Blendify) Since the Repeat Last operator in the IC keymap is using G there is no keymap conflict there. So I'll leave the remaining shortcuts as they are.

Aaron Carlisle (Blendify) added a comment.Dec 14 2022, 4:02 AM

VIEW3D_MT_angle_control is now unused and can be removed.

Julien Kaspar (JulienKaspar) updated this revision to Diff 59519.Tue, Jan 17, 12:34 PM

Removed VIEW3D_MT_angle_control

Harbormaster completed remote builds in B25398: Diff 59519.Tue, Jan 17, 12:34 PM
Aaron Carlisle (Blendify) accepted this revision.Wed, Jan 18, 3:41 AM
This revision is now accepted and ready to land.Wed, Jan 18, 3:41 AM
Closed by commit rB3e9039091870: Sculpt: Resolve `Shift R` shortcut conflicts (authored by Aaron Carlisle (Blendify), committed by Joseph Eagar (joeedh)). · Explain WhyFri, Jan 27, 1:56 AM
This revision was automatically updated to reflect the committed changes.
Joseph Eagar (joeedh) added a commit: rB3e9039091870: Sculpt: Resolve `Shift R` shortcut conflicts.
ronan ducluzeau (zeauro) added a subscriber: ronan ducluzeau (zeauro).EditedFri, Jan 27, 4:53 PM

R could be used for transform operations.
In 3.3, if you press R, you can rotate unmasked unhidden mesh.
When R has been pressed, pressing G can move unmasked unhidden mesh parts.
So, R -> rotate. R, G -> move. R, S -> Scale.

If G and S are not provoking transform operations, they were used by brushes. G is used by Grab Brush. S was used by smooth. R by Angle Control.
There could have been a coherence with brushes use. G to Grab, R to Rotate brush, S to Inflate.

S was remapped to sample color for painting color attributes. The choice of coherence with paint modes was done.

Currently, there are custom active tools with gizmos. There are preferences to map G,R,S to those tools in other modes.
The choice of coherence with Object and Edit mode could be done to avoid to add custom shortcuts to transform in Sculpt mode.

We have 9 brushes that have different deformation modes.
Smooth, Elastic Deform, Snake Hook, Pose, Slide Relax, Boundary, Cloth, Multires Displacement, Smear.
2 trim tools that have trim modes.
1 Edit Face Set tool that has modes.
And 4 transform tools have transform modes.
One shortcut is needed to set mode.

To me, that would make sense to keep GRS to transform, in sculpt mode, and choose Y to Grab brush, V to Voxel Remesh and U or J to sample color.
That way , GRS could be complementary to brushes with deformation modes.

Julien Kaspar (JulienKaspar) added a comment.Fri, Jan 27, 5:39 PM

@ronan ducluzeau (zeauro) Sorry but that is a far more involved change that changes default shortcuts across many modes.
That was out of the scope for this patch.

Revision Contents
Changeset List

PathSize
release/
scripts/
presets/
keyconfig/
keymap_data/
13 lines

Diff 57639

View Options

release/scripts/presets/keyconfig/keymap_data/blender_default.py

Loading...