Small fix for geonode switch node.
ClosedPublic
Actions

Authored by Martijn Versteegh (Baardaap) on Nov 15 2022, 12:34 PM.

Details

Reviewers

Commits

rBe257e2e07592: Fix: Link drag search crash with incorrect socket name in switch node
rBc0df88f3b51c: Fix: Link drag search crash with incorrect socket name in switch node

Summary

When dragging a boolean node, releasing and searching for switch and then picking the 'Switch' socket blender crashes.

When connecting a dragged noodle to a new switch node and selecting the 'Switch' socket, the socket name was set to 'Start' but it should be 'Switch'.

Diff Detail

Event Timeline

Martijn Versteegh (Baardaap) requested review of this revision.Nov 15 2022, 12:34 PM

Martijn Versteegh (Baardaap) created this revision.

Seems to need update_and_connect_available_socket to work properly.

This revision is now accepted and ready to land.Nov 15 2022, 1:03 PM

Use update_and_connect_available_socket() instead of connect_available_socket()

Closed by commit rBc0df88f3b51c: Fix: Link drag search crash with incorrect socket name in switch node (authored by Martijn Versteegh (Baardaap)). · Explain WhyNov 15 2022, 10:13 PM

This revision was automatically updated to reflect the committed changes.

Martijn Versteegh (Baardaap) added a commit: rBc0df88f3b51c: Fix: Link drag search crash with incorrect socket name in switch node.

Martijn Versteegh (Baardaap) added a comment.Nov 15 2022, 10:15 PM

This comment was removed by Martijn Versteegh (Baardaap).

Philipp Oeser (lichtwerk) added a commit: rBe257e2e07592: Fix: Link drag search crash with incorrect socket name in switch node.Nov 28 2022, 2:56 PM

Revision Contents
Changeset List

Path

Size

source/

blender/

nodes/

geometry/

nodes/

node_geo_switch.cc

2 lines

Diff 57673

View Options

source/blender/nodes/geometry/nodes/node_geo_switch.cc

Small fix for geonode switch node.ClosedPublicActions