Page MenuHome
Differential D16517

Fix T101211: Image jitters when scaling by large values
ClosedPublic
Actions

Authored by Richard Antalik (ISS) on Nov 15 2022, 7:27 PM.

Details

Reviewers
Jeroen Bakker (jbakker)
Maniphest Tasks
T101211: VSE Image Strip transform jitters under extreme scaling, unlike the smooth transform strip and compositor transform node.
Commits
rB3a65d2f5911c: Fix T101211: Image jitters when scaling by large values
Summary

Issue was caused by imprecise math due to using float numbers.
Use double instead.

No negative performance impact was observed.

Diff Detail

Repository
rB Blender

Event Timeline

Richard Antalik (ISS) requested review of this revision.Nov 15 2022, 7:27 PM
Richard Antalik (ISS) created this revision.
Harbormaster completed remote builds in B24664: Diff 57664.Nov 15 2022, 7:27 PM
Jesse Yurkovich (deadpin) added a subscriber: Jesse Yurkovich (deadpin).Nov 15 2022, 7:44 PM
Jesse Yurkovich (deadpin) added inline comments.
source/blender/imbuf/intern/transform.cc
473–474

Seems these lines were left in by mistake?

Richard Antalik (ISS) updated this revision to Diff 57700.Nov 16 2022, 4:29 PM
Richard Antalik (ISS) marked an inline comment as done.

Remove unintentional changes

Harbormaster completed remote builds in B24672: Diff 57700.Nov 16 2022, 4:29 PM
Jeroen Bakker (jbakker) added a comment.Nov 18 2022, 9:17 AM

Modern processors use double math internally. So this patch has minimum overhead. Fine by me. Would just make the return values consistent.

source/blender/imbuf/intern/transform.cc
211

would also make the return type double so it matches the change in the arguments.
Same or modify_v

Jeroen Bakker (jbakker) requested changes to this revision.Nov 18 2022, 9:17 AM
This revision now requires changes to proceed.Nov 18 2022, 9:17 AM
Richard Antalik (ISS) updated this revision to Diff 57781.Nov 18 2022, 5:40 PM

Use double type for UV wrappers

Harbormaster completed remote builds in B24723: Diff 57781.Nov 18 2022, 5:40 PM
Richard Antalik (ISS) marked an inline comment as done.Nov 18 2022, 5:40 PM
Jeroen Bakker (jbakker) accepted this revision.Nov 23 2022, 2:41 PM
This revision is now accepted and ready to land.Nov 23 2022, 2:41 PM
Closed by commit rB3a65d2f5911c: Fix T101211: Image jitters when scaling by large values (authored by Richard Antalik (ISS)). · Explain WhyNov 27 2022, 9:42 PM
This revision was automatically updated to reflect the committed changes.
Richard Antalik (ISS) added a commit: rB3a65d2f5911c: Fix T101211: Image jitters when scaling by large values.

Revision Contents
Changeset List

PathSize
source/
blender/
blenlib/
2 lines
intern/
12 lines
imbuf/
intern/
100 lines

Diff 58089

View Options

source/blender/blenlib/BLI_math_vector.h

Loading...
View Options

source/blender/blenlib/intern/math_vector_inline.c

Loading...
View Options

source/blender/imbuf/intern/transform.cc

Loading...