Improve performance test constraint
Needs ReviewPublic
Actions

Authored by Monique Dewanchand (mdewanchand) on Nov 17 2022, 4:26 PM.

Details

Reviewers

Summary

Test constraint checks whether an object exists in the bmain. Instead of looping through all the objects in bmain you can also check the ID flag. This should be faster.

Diff Detail

Repository

rB Blender

Branch

improve_performance_test_constraint (branched from master)

Build Status

Buildable 24692
Build 24692: arc lint + arc unit

Event Timeline

Monique Dewanchand (mdewanchand) created this revision.Nov 17 2022, 4:26 PM

Harbormaster completed remote builds in B24692: Diff 57738.Nov 17 2022, 4:26 PM

Monique Dewanchand (mdewanchand) requested review of this revision.Nov 17 2022, 4:29 PM

Monique Dewanchand (mdewanchand) retitled this revision from Test constraint checks whether an object exists in the bmain. Instead of looping through all the objects in bmain you can also check the ID flag. This should be faster. to Improve performance test constraint.

Monique Dewanchand (mdewanchand) edited the summary of this revision. (Show Details)

Monique Dewanchand (mdewanchand) added a reviewer: Bastien Montagne (mont29).

Monique Dewanchand (mdewanchand) added a project: Core.

I don't think we can make such changes until T88555: ID Management: Sanitize and clarify our ID tags has been addressed, currently relying on tags to know if an ID is in G_MAIN or not is... risky at best.

Bastien Montagne (mont29) mentioned this in D16450: Optimize check on non editable name for evaluated ID's or embedded ID's..Nov 18 2022, 11:42 AM

Revision Contents
Changeset List

Path

Size

source/

blender/

blenkernel/

intern/

object.cc

14 lines

Diff 57738

View Options

source/blender/blenkernel/intern/object.cc

Improve performance test constraintNeeds ReviewPublicActions