Page MenuHome
Differential D16542

Fix T102514: wrong scene reported for missing compositing camera
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Nov 18 2022, 2:29 PM.

Details

Reviewers
Sergey Sharybin (sergey)
Brecht Van Lommel (brecht)
Maniphest Tasks
T102514: No Camera Found in Scene - Not True
Commits
rBa274718e7d36: Fix T102514: wrong scene reported for missing compositing camera
rB9e0fcd575572: Fix T102514: wrong scene reported for missing compositing camera
rB63c4ec89e123: Fix T102514: wrong scene reported for missing compositing camera
Summary

If compositing uses renderlayers, and a camera was missing in the
associated scenes, the error message also referred to the scene the comp
tree was in (not the scene of the renderlayer -- which can potentionally
be different).

This was confusing and is now rectified.

Diff Detail

Repository
rB Blender
Branch
T102514 (branched from master)
Build Status
Buildable 24716
Build 24716: arc lint + arc unit

Event Timeline

Philipp Oeser (lichtwerk) requested review of this revision.Nov 18 2022, 2:29 PM
Philipp Oeser (lichtwerk) created this revision.
Harbormaster completed remote builds in B24716: Diff 57774.Nov 18 2022, 2:29 PM
Philipp Oeser (lichtwerk) added projects: Render Pipeline, VFX & Video, Compositing.Nov 18 2022, 2:30 PM
Brecht Van Lommel (brecht) requested changes to this revision.Nov 18 2022, 2:49 PM

Functionally fine, but I think the code would be simpler if ReportList *reports was passed as an argument to check_valid_compositing_camera.

This revision now requires changes to proceed.Nov 18 2022, 2:49 PM
Philipp Oeser (lichtwerk) updated this revision to Diff 57818.Nov 19 2022, 1:09 PM

pass ReportList to check_valid_compositing_camera

Harbormaster completed remote builds in B24738: Diff 57818.Nov 19 2022, 1:09 PM
Brecht Van Lommel (brecht) accepted this revision.Nov 19 2022, 2:13 PM
This revision is now accepted and ready to land.Nov 19 2022, 2:13 PM
Closed by commit rB63c4ec89e123: Fix T102514: wrong scene reported for missing compositing camera (authored by Philipp Oeser (lichtwerk)). · Explain WhyNov 19 2022, 8:47 PM
This revision was automatically updated to reflect the committed changes.
Philipp Oeser (lichtwerk) added a commit: rB63c4ec89e123: Fix T102514: wrong scene reported for missing compositing camera.
Philipp Oeser (lichtwerk) added a commit: rB9e0fcd575572: Fix T102514: wrong scene reported for missing compositing camera.Dec 14 2022, 2:43 PM
Philipp Oeser (lichtwerk) added a commit: rBa274718e7d36: Fix T102514: wrong scene reported for missing compositing camera.Jan 12 2023, 2:07 PM

Revision Contents
Changeset List

PathSize
source/
blender/
render/
intern/
20 lines

Diff 57774

View Options

source/blender/render/intern/pipeline.cc

Loading...